fix: update GH API requests to handle rest client param encoding

• fix: split combined PathParam into individual parts to address encoding

reactive rest client encodes string params which breaks some of our API calls. This splits them back out properly to address the issue

• Set min log level to TRACE for better on demand debugging

• Add more trace logs around GH validation for debugging

• Fix: fix isolation breaking passed params for error template

requested review from @cguindon and @malowe

requested review from @heurtemattes

@heurtemattes let me know if you need context for any of the changes! The field that's changing is stored in the DB as a combined string, so rather than updating DB and creating migration, I'm just handling it after loading. This was done as the new REST lib used in latest SDK encodes the parameters passed, leading to a URL similar to github.com/repos/eclipsefdn%2fspider.pig/pulls/12, which isn't valid.

FYI @netomi, this is the patch we need to go live to production. I've tested on staging already since I can't test the fix locally.

I guess its hard to determine from the diff view if the changes are fine, we should really try to deploy it to staging and testing it so that we can move that to production asap as I am currently blocked by having the otterdog app not whitelisted for eca.

added 1 commit

• 7410d83a - update: Add call to generate full repo name to GH validation helper

Compare with previous version

mentioned in commit c673bf88

merged