Skip to content
Snippets Groups Projects
Jordi Gómez's avatar
  • f9a74562 · feat: migrating some Autovalue classes to records + small changes
Jordi Gómez's avatar
commented on merge request !222 "feat: notifying users with a message when PR validation fails" at Eclipse Foundation / IT / APIs / Git ECA API

updated!

Jordi Gómez's avatar
commented on merge request !222 "feat: notifying users with a message when PR validation fails" at Eclipse Foundation / IT / APIs / Git ECA API

that's a thousand times better, thanks! updated

Jordi Gómez's avatar
commented on merge request !222 "feat: notifying users with a message when PR validation fails" at Eclipse Foundation / IT / APIs / Git ECA API

didn't know that, updated

Jordi Gómez's avatar
commented on merge request !222 "feat: notifying users with a message when PR validation fails" at Eclipse Foundation / IT / APIs / Git ECA API

updated

Jordi Gómez's avatar
commented on merge request !222 "feat: notifying users with a message when PR validation fails" at Eclipse Foundation / IT / APIs / Git ECA API

good catch, I'm also adding that to the updateCommitStatus that's also logging this info

Jordi Gómez's avatar
  • 9fa1dbe9 · feat: migrating some Autovalue classes to records + small changes
Martin Lowe's avatar
commented on merge request !222 "feat: notifying users with a message when PR validation fails" at Eclipse Foundation / IT / APIs / Git ECA API

The build is currently failing due to a missing build artefact. I couldn't properly rebuild the old versions, so we're just upgrading as needed to ...

Martin Lowe's avatar
commented on merge request !222 "feat: notifying users with a message when PR validation fails" at Eclipse Foundation / IT / APIs / Git ECA API

since we're doing calculations here, we should wrap this in a if (LOGGER.isTraceEnabled()) { ... }. Most of the time the processing is hitting a ge...

Martin Lowe's avatar
commented on merge request !222 "feat: notifying users with a message when PR validation fails" at Eclipse Foundation / IT / APIs / Git ECA API

We shouldn't do this forever, just in case something changes in how data is returned. I'd just say add a condition like page < 50, as a PR shouldn'...

Martin Lowe's avatar
commented on merge request !222 "feat: notifying users with a message when PR validation fails" at Eclipse Foundation / IT / APIs / Git ECA API

Objects.isNull isn't meant to be used in conditionals like this, but instead as a predicate in streams for easier calling. In cases like this, you ...

Martin Lowe's avatar
commented on merge request !222 "feat: notifying users with a message when PR validation fails" at Eclipse Foundation / IT / APIs / Git ECA API

Is there a reason to use AutoValue here? We've been trying to move to records so that we can remove AutoValue eventually

Martin Lowe's avatar
commented on merge request !222 "feat: notifying users with a message when PR validation fails" at Eclipse Foundation / IT / APIs / Git ECA API

See the following guide for how to do config mappings, as we should use that for this sort of object: https://quarkus.io/guides/config-mappings

Jordi Gómez's avatar
  • 23e3f8b4 · fix: updating gh IssueComment usage
Jordi Gómez's avatar
  • 8b051c71 · chore: removing unused class
Jordi Gómez's avatar
commented on merge request !222 "feat: notifying users with a message when PR validation fails" at Eclipse Foundation / IT / APIs / Git ECA API

@malowe Now that I'm finally using the proper API, this should work once we add the correct permissions to the installation and configure the bot I...

Jordi Gómez's avatar
Jordi Gómez's avatar
  • 1781d1ee · feat: using github issues API to send messages
Jordi Gómez's avatar
commented on merge request !223 "Draft: docs: adding mermaid sequence diagram displaying the current picture" at Eclipse Foundation / IT / APIs / Git ECA API

Nice to hear that!...

Jordi Gómez's avatar
commented on merge request !222 "feat: notifying users with a message when PR validation fails" at Eclipse Foundation / IT / APIs / Git ECA API

Moving it back to draft....