fix: Make engine set name of controller(s)

requested review from @arauschert

Has been tested with openPASS (internal develop state)

Would work, but a bit weird that the name is not defined upon construction of the controller and only set later optionally by each engine. Did you think about moving the "name" member from ExternalControllerConfig to IControllerConfig? https://gitlab.eclipse.org/eclipse/openpass/mantle-api/-/blob/master/include/MantleAPI/Traffic/i_controller_config.h?ref_type=heads#L83 Then every controller could get its name directly upon construction.

No - I was not aware of that option.

I like make the mantle_api even more agnostic w.r.t openSCENARIO and NOT to differentiate between internal and external controller.

We could simply use a ControllerConfig. The simulator then has to know when to internal controller is instantiated. I could imagine, that the differentiation is done by the simulator when receiving a controller with name "OpenScenarioEngine::v1_2::Default", an empty string, or simply the first controller created.

We are using the derived Internal/ExternalController classes already in the environment, which is an easier way to distinguish instead of expecting certain names. So I wouldn't delete the Internal/ExternalController classes.