Integrate license check into the build

We currently have a separate build for the third party license check. We could integrate it into our main build. That way, if we change any dependencies, the build for merge request will fail, and we can update the dependencies file before merging to develop.

added RelEng/DevOps TypeEnhancement labels

There was confusion about the build not doing this check, see !303 (comment 695078)

mentioned in merge request !303 (merged)

marked this issue as related to #160

mentioned in issue #476 (closed)

As I experienced in #476 (closed), we do forgot to update the DEPENDENCIES.txt file every now and then. The changes in this issue would mean that we can't forget anymore, as the build would then fail, preventing that we can merge to develop.

Is there a reason not to activate this check? In my experience, running the check takes little time. Fixing failing dependencies in the develop branch is quite a hassle (Create Issue, create branch, update DEPENDENCIES.txt, commit, create Merge Request, wait for build to pass, merge).

The only reason I can think of, is that we don't necessarily have to check this for a release. It is more a continuous thing. So, if a dependency suddenly no longer is supported, and this is a false positive, the build will fail. This is fine for develop. But then we also can't release. However, that is probably super rare. So, the benefits outweigh the downsides, I think. So, just a matter of doing it then, I think.

changed title from Consider integrating license check into the build to Integrate license check into the build

I've renamed the issue to indicate we no longer just consider this, but want to actually do it.

assigned to @ddennis

created branch 360-integrate-license-check-into-the-build to address this issue

One issue I've noticed is that we get a lot of warnings. They were always there, but I ignored them. If we make it part of the build, the 1481 warnings are a bit annoying. I've reported the issue to the Dash license tool: https://github.com/eclipse/dash-licenses/issues/199

It seems a solution to https://github.com/eclipse/dash-licenses/issues/199 has been found, but it is being tested still.

The solution should now be available. I'll test it.

https://github.com/eclipse/dash-licenses/issues/199 indicated on 2023-04-28:

This change broke some builds (see https://github.com/eclipse/dash-licenses/issues/232). I've reverted the change and am reopening this.

mentioned in commit 1f5b7433

mentioned in commit 70d998ec

mentioned in commit 6b274f22

mentioned in commit 614e97ad

mentioned in commit a05af1ac

mentioned in commit 55c4b46f

mentioned in commit e145709e

mentioned in commit 90d18e61

mentioned in commit 7eaf4cf2

mentioned in commit 3de31377

mentioned in commit c914ff9d

mentioned in merge request !454 (closed)

changed milestone to %v0.9

mentioned in issue #495 (closed)

changed milestone to %v0.10

mentioned in commit 98ff4cc3

changed milestone to %v1.0

I'll remove this from milestone %v1.0, as it is unlikely the Dash license check tool gets fixed any time soon, as the request has been open for a long time, and the fix that was done earlier led to all kinds of side-effects.

removed milestone %v1.0

unassigned @ddennis

mentioned in issue #726

marked this issue as related to #726

mentioned in merge request !788 (merged)