Implement proposal in #212
Implement proposal in #212 (closed): add error if GraphView::replace() is used with two sets for the following conditions:
Inputs conditions:
| old \ new | 1 node, 1 input | >1 node, 1 input | 1 node, >1 inputs | >1 node, >1 inputs |
|---|---|---|---|---|
| 1 node, 1 input | trivial | trivial | broadcast | broadcast |
| >1 node, 1 input | trivial | trivial | broadcast | broadcast |
| 1 node, >1 inputs | (take first) | (take first) | same order | X |
| >1 node, >1 inputs | X | X | X | X |
Outputs conditions:
| old \ new | 1 node, 1 output | >1 node, 1 output | 1 node, >1 outputs | >1 node, >1 outputs |
|---|---|---|---|---|
| 1 node, 1 output | trivial | trivial | take first | X |
| >1 node, 1 output | trivial | trivial | take first | X |
| 1 node, >1 outputs | (take first) | (take first) | same order | X |
| >1 node, >1 outputs | X | X | X | X |
Only the X cases cannot possibly be resolved deterministically with sets of node.
These cases are therefore forbidden for the set-based replace() interface.
The remaining cases are handled by the GraphView-based replace() interface.
If they are not supported, the function returns false.
Merge request reports
Activity
added Enhancement ⭐ label
assigned to @olivierbichler
mentioned in issue #212 (closed)
enabled an automatic merge when all merge checks for dc1fe726 pass
aborted the automatic merge because the source branch was updated. Learn more.
enabled an automatic merge when all merge checks for 4057db9e pass
mentioned in commit 6de11c4b
changed milestone to %aidge v0.6.0