Replace not working for sets

Problem description

When using the replace function with sets of Nodes in input (not GraphViews) and there are several inputs or output for both sets (the same number, of course) as the set is not ordered there is no way to predict or control which former Input (or Output) will be linked with which new Input (or Output) the result is random and such cases may lead to incoherence in the new Model.l'utilisateur.

Possible solutions

• Limit (or remove) the replace variant using sets of Nodes

added Bug 🐛 label

assigned to @operrin

Adding a check on the number of i/o of the graph to replace will fix this issue.

For this issue multiple solution can be given.

• Provide the possibility to set a RootNode for both set which will force a deterministic ordering of the inputs nodes
• Raise an error when trying to replace via the set signature a graphview with more than one input or output

mentioned in commit dc1fe726

mentioned in merge request !334 (merged)

Fixed in !334 (merged).

closed

mentioned in commit 6de11c4b