Marketplace D9 Feedback from Christopher Guindon

Mobile view

• Main-menu
  • The menu is open by default. I would expect to see the hamburger menu that allows users to expand mobile menu
  • Remove the community, participate, Eclipse IDE and search from mobile menu. I think this should be a setting in the theme that allows us to enable or disable these mobile links. Refer to mobile menu on production for expected behavior
  • My Marketplace Link
    • This link should point users to /user/%user/favorites (now /listings)
    • The link is missing when the user is logged in
• Content order
  • On mobile, I would expect the main content area to be shown before the sidebar. Refer to the production site for expected behavior

General

• Content types with a “additional author” must allow those users to edit that content. They should be treated the same was an the Author.
• Moderation is required for all new node submitted by an non-admin user.
• The clear cache will sometimes result in a time-out. We should consider increasing resources in OKD.
  • It’s worth nothing that the staging database has less resources that the production one if we think that’s the bottleneck. We should do some profiling to better understand the bottlenecks before we push to production
• The Last Updated sorting should be the default for Listing Views such a /taxonomy/term/4396%2C4988
• URL field descriptions are generally misleading. In most cases, the URL should be external URL.
  • It should not be possible to select an internal path for these fields. Let’s chat if you find an exception to that rule.
• Improve metatags default configs
  • Make sure to remove <meta name="robots" content="noindex, nofollow, noarchive, nosnippet, noimageindex, notranslate" /> for production
  • We should define proper description and keywords metatags for the homepage
  • For content type, we can use the tag field for keywords and the teaser for description
  • We should also consider improving metatags for view pages
• URL aliases for error reports are not properly configured because of the ordering on /admin/config/search/path/patterns.
  • It uses the content-default pattern rather than the Content - Error Report pattern.
• PHP warning seen in the logs that require furter investigation:
  • Warning: file_get_contents(libraries/colorbox/jquery.colorbox-min.js): Failed to open stream: No such file or directory in Drupal\Core\Asset\JsCollectionOptimizer->optimize() (line 123 of /web/core/lib/Drupal/Core/Asset/JsCollectionOptimizer.php)
  • Drupal\search_api\SearchApiException: The datasource with ID '1f2b1h--entity:node' could not be retrieved for index 'Resources (Listings)'. in Drupal\search_api\Entity\Index->getDatasource() (line 369 of /web/modules/contrib/search_api/src/Entity/Index.php).
  • Theme hook markup not found.
  • InvalidArgumentException: The user-entered string 'access-denied' must begin with a '/', '?', or '#'. in Drupal\Core\Url::fromUserInput() (line 216 of /web/core/lib/Drupal/Core/Url.php)
  • Warning: Undefined array key "function" in Drupal\Core\Utility\Error::getLastCaller() (line 130 of /web/core/lib/Drupal/Core/Utility/Error.php)

Homepage

• Search block
  • Move the **Search **button next to the Market field dropdown to reduce the size of the block
• Spotlight is missing on the front page.
  • The front page spotlight should display featured listings. If there is no featured listing, then it’s fine to hide that block. I did make sure to add listings to that field.
• I would like to recommend that we remove HTML from rss feed. Use plain text format and apply this to all rss feed. I think that will make the feeds more useful.

REST API

• If featured listings were defined, they should be listed on the first page when MPC is open. I believe this is the featured API call.

Comments

• When we allow comments for a node, the section should be labeled as listings (Add a Review). This applies to all content types. We should be consistent here.
• Missing indent when a comment is a reply to another comment.
• Make sure that comments are diabled for:
  • LTS
  • Training Consulting
  • Error Reports
  • MPC ADS
  • Catalogs
• Content type that allows comment should have the following info block
  • For support-related enquiries, please refer to the listing support page or ask your questions on the Eclipse Forums.
    • If the node does not provide a support page, only point users to the forums
• Users with less than 5 approved comments must be moderated. Users with 5 or more approved comments, can by-pass moderation.
• The dropdown for the text-filter has a padding issue that hides half of the text.

Content pages

/content/add-content

• Broken links for
  • Add a new IoT Package Listing NEW
  • Add a new LTS Maintenance Provider Listing
• It should not be possible for user to subscribe to comments when the page does NOT allow comments. It should not be possible for users to post comments here.
• There is also an option to subscribe to page content type.
  • We should remove that.
• Add link for the Welcome to Eclipse page since we won’t add it to the footer like we did in D7: https://marketplace.eclipse.org/content/welcome-eclipse-marketplace

User pages #203 (closed)

• /user/%user/edit
  • Should redirect users to accounts.eclipse.org/user/edit
• /user/register
  • should be redirecting to accounts.eclipse.org/user/register
• user/password
  • should be redirecting to accounts.eclipse.org/user/password
  • You should be able to solve these issues by enabling that eclipsefdn_user module that you created
• user/%user/view
  • That page should redirect to accounts.eclipse.org/users/:username
• user/%user/
  • Should redirect to /user/%user/favorites or make /user/%user/favorites the default tab now /user/listings https://gitlab.eclipse.org/eclipsefdn/it/websites/drupal/eclipsefdn/-/merge_requests/184#note_1204068
• /user/%user/listings
  • View own unpublished listings
  • I am getting a _The website encountered an unexpected error. Please try again later _error with the webdev account
    • https://marketplace-staging-d9.eclipse.org/user/webdev/listings
  • I would expect the content area to have a “no result” message if I don’t have any products. Try:
    • It appears that you haven't submitted any products on this site yet. This space is intended to showcase products authored by you or those where you are listed as an additional author
  • Products where the user is listed as an additional are not showing on the list
• /user/%user/favorites
  • We should allow users to edit their favorite list
    • I don’t think this feature provides any value. Let’s drop this in Drupal 9.
• /user/%user/notifications
  • It should not be possible for other to view my notifications. This is a new feature but I don’t think we need it. Let’s remove it or make it only accessible by users with the moderation role.
• /user/%user/subscriptions
  • I would expect this to be wrapped in our white block container .eclipsefdn-block-white-bg. Note that .solstice-block-white-bg was deprecated in D9 and should not be used.

Eclipse Listings

• /node/%listing/edit
  • Possible migration issue: https://marketplace-staging-d9.eclipse.org/content/php-development-tools/edit
    • Looks like we have an issue with the feature ids? It does not look like it was migrated correctly and I can't edit. I am concerns that this is not the only listing with that issue. We should investigate.
  • Solution Name field should be a required field
  • Users should only be allowed to pick 1 market and the Eclipse Project market should not be an option for the author to pick.
    • However, if the node is saved and ALL of it’s update site originates from download.eclipse.org, then we programmatically add the Eclipse Market to the listing.
    • The Eclipse Project market should be removed if the node is updated and it’s update sites no longer points to downloads.eclipse.org
  • Solution version
    • What is the purpose of the “Resource listing rel…” text. I think that should be removed since it’s not really explaining anything.
    • There should be space between fields when displaying solution version “paragraph (drupal term, not an actual parapraph)” on the edit form
    • The Add Resources listing release to Solution Version button should rather say: Add Solution version to Listing
  • I am getting the “The website encountered an unexpected error. Please try again later.” error when visiting the edit page with a user who should not have access to edit
• /node/%listing/view
  • Node links
    • I would use the class .btn-sm for each links. Not convinced we should use .btn-danger and .btn-success here. The .btn-info or .btn-default classes are a better fit in my opinion. The red and green catches to much of my attention.
    • Add some padding between the content tabs and the links. The button are currently touching the tab border.
      • There should also be some padding below each links so that they don’t touch if they span over more than 1 line
    • Subscribe text:
      • There is too much text here. I think it should say something like:
        • Subscribe to comments
        • Subscribe to content update
      • When you are subscribed, the button text needs to be updated to says “Unsubscribe to”. Changing the color to red is not enoug from a usability standpoint.
  • Comments
    • All comments needs to go to moderation before being published. See comment section for exceptions.
    • Remove Add new comment link. Not needed since the form is right below it.
  • The screenshot open in the browser. The user must click back to continue navigating the site.
  • Metrics tab
    • is missing a static link to “View Data for all Listings”
  • Error tab
    • Download the last 500 error floats on top of the tabs
    • Clear unsuccessful install button returns an error: The website encountered an unexpected error. Please try again later.
  • Favorited by block
    • Links in that section should point to the user favorite page
  • Search Block
    • The advanced search section is too big. Please reduce the height and add arrows to indicate that it can be expanded like the D7 website.
      • I am fine with the new gray color
  • Publish tab/button
    • Users should not be allowed to bypass moderation. The publish button should send the listing in our moderation workflow.
      • The user needs to be informed that their listing was sent to moderation before publishing.
  • Details tab
    • Submitted by is missing. The name of the user should link to their product page
  • Add to X Marketplace catalog
    • On production, my user, cguindon, has access to edit the Obeo catalog since I am listed as an additional author.
      • I am missing the link to add to the obeo catalog. I assume it’s not granting edit access to users listed in the additional author field.

Marketplace Catalogs

• /node/%catalog/view
  • I am currently getting a The website encountered an unexpected error. Please try again later when trying to view a catalog node.
    • I can;t review this section further until that’s fixed.
• /node/%catalog/edit
  • I am currently getting a The website encountered an unexpected error. Please try again later when trying to edit a catalog node with a user who should NOT have access (not the author and not listed as an additional author).

Mpc-ads

• node/%mpc_ads/edit
  • The admin theme does not load on this page. I tried clearing the cache twice but the issue persisted.
    • I believe this issue is tied to user 1.
    • Admin theme seems to load fine with a regular account. Other node edit forms are impacted as-well not just mpc_ads.
• node/%mpc_ads/view
  • Metrics tab does not work.

Error reports

• /node/%error_report/view
  • Labels should match what we have in Drupal 7. For example, https://marketplace.eclipse.org/content/error/report/5653929
    • Read status => Read status:
    • Listings => Listings:
    • Status => Error Code:
    • Status message => Error Message:
    • Feature IDs => Installable Units Reported:
    • Error message => Detailed Message:

IoT Listings #199 (closed)

• /node/%iot_package/edit
  • Name of IoT Package should be required.
  • Missing field group for the IoT Smarthome and IoT Kura section. I think that it’s important that we group that section from a UX perspective
    • The title of each group should be Eclipse Kura and Eclipse SmartHome not Iot smarthome and Iot package kura
  • URL field descriptions are misleading. These should always be external URL. It should not be possible to select an internal path for these fields.
• /node/%iot_package/view
  • Category label should be renamed to IoT Categories
  • Missing fields in the additional details section
    • Organization URL
    • Submitted By

Training and consulting

• /node/%training/edit
  • The Eclipse Project market should not be an option.
• /node/%training/view
  • Missing fields in the additional details section
    • Submitted By
  • Disable comments for this content-type.

LTS Provider #200 (closed)

• /node/%lts_provider/edit
  • Maintenance provider name / Company Name should be required
  • URL field descriptions are misleading. These should always be external URL. It should not be possible to select an internal path for these fields.
    • Same for the Project URL
  • The add LTS supported projects button should be labeled as + Add another item
• /node/%lts_provider/view
  • The country/Region field is missing in the description section
  • Supported Project field group is missing
  • Keep the Additional detail section and add the missing Submitted by: field.
  • Disable comments for this content-type.

added Drupal 9 team:webdev labels

changed title from Staging feedback: to Marketplace D9 Feedback from Christopher Guindon

assigned to @theodoreb

changed the description

added to epic &22 (closed)

added statetodo label

added priorityhigh label

added severitynormal label

marked this issue as blocking #196 (closed)

removed the relation with #196 (closed)

marked this issue as blocking #195 (closed)

mentioned in issue #195 (closed)

added statewip label and removed statetodo label

• The Last Updated sorting should be the default for Listing Views such a /taxonomy/term/4396%2C4988

On prod the default sorting is "Foundation members", it needs to be opened in an incognito window, there is a cookie that might get in the way. Happy to change the default if it's still the default you'd like.

On prod, the sorting is stored in a cookie. If you change it, that will be your default.

I don't think we need to implement the cookie for storing the default sort as I think sorting Last Updated will bring the solutions that were updated recently more front and center.

This will encourage users to keep their listings up-to-date.

works for me

mentioned in issue #199 (closed)

changed the description

changed the description