ECA required for members with MCCA

As reported by @mplagge, companies which signed an MCCA (Member Commiter and Contribution Agreement) are still required to fill in the ECA when creating the Eclipse Foundation account.

I was able to reproduce this behavior with a test account.

assigned to @epoirier

added Bug prioritymedium severitynormal statetodo team:webdev labels

unassigned @epoirier

@wbeaton can you please advice what the process is here? Should the https://accounts.eclipse.org web UI be modified so that Employees of MCCA signatories are not prompted to agree to ECA?

/cc @epoirier

A developer who is covered by an MCCA or ICA should not have to sign the ECA.

Thanks for the clarification @wbeaton.

@jmazanek4ep let's close this issue as it seems to be working as expected.

closed

@epoirier maybe I don't understand something, but the reported issue is precisely that developer covered by MCCA ( for example as an employee of Mercedes-Benz) is still prompted to agree to ECA when creating the EF account. Is this working as expected, or should the prompt be skipped?

@jmazanek4ep To my knowledge this is working as expected.

As mentioned by Wayne above, even when covered by an MCCA, users still need to complete the ECA form on accounts.eclipse.org.

A developer who is covered by an MCCA or ICA should not have to sign the ECA.

Isn't the meaning the opposite? I am confused

@jmazanek4ep my bad I misread.. You are correct, the ECA doesn't need to be signed as per Wayne's comment.

I'll investigate the code to see what's going on here.

reopened

/cc @mplagge

assigned to @epoirier

@mplagge, I'm looking into the code and it seems to be doing what it should in terms of finding out if users needs to sign an ECA or not.

I can see that it is checking if the user is working for a compagny that signed an MCCA.

Can you provide the username and organization that are having issues? I'll be able to better pin point the issue with this information.

Thanks.

/cc @jmazanek4ep

@jmazanek4ep did you use a test account on production? If so, can you provide the username and org?

Thanks.

Hi @epoirier,

the observation was shared by developers at Mercedes via Sibel Acikgöz BU Governance & Business Services Team Compliance & Legal Mercedes-Benz Tech Innovation GmbH

But Sibel was just collecting/communicating the feedback, she never tried to setup an account herself.

Just one idea what could raise the problem: In the "Create your account" form there is a drop-down field called "Eclipse Member Organization" (in case you select "Work for an Eclipse Member Organization" under "What is your employment status"). This drop-down field contains all direct EF members, but not the associated affiliates (and we can't solve this at this level). So there may a situation where a developer directly from Mercedes wants to register but only finds "Mercedes Benz Tech Innovation Gmbh" in the drop down list. As he may not be aware of our affiliate regulations he may assume that he needs to choose a different option (like "Others") and ends up with the request to sign an ECA.

Not sure if the above is what happened at Mercedes. However I think adding an info about "Affiliates" into the registration form may be helpful. WDYT?

BR --Michael

@epoirier @jmazanek4ep

Is there a progress here (not sure if the two of you may be on your well-deserved vacation)? Maybe I can reach out to Mercedes to offer that we run the registration process with one of their employees jointly?

BR --Michael

Hi @mplagge,

I'm back from a week of vacation, can you provide a username so I can have a better feel of what is going on with the user's account?

Thanks.

I think the issue here is the ECA appears to be required but it's not. We are currently making improvements for this via #47 (closed)

User's can sign it but they don't need to. For those users, there should be information about their state on the page:

Your contributions to Eclipse Foundation projects are covered by your employer's Member Committer and Contributor (Version 4.0.2).

I think the issue here is that if we detect that you don't have an ECA on file, we redirect users to the ECA form.

We can improve this by detecting if the user is covered by an MCCA v4 or ICA v4. If they do, we redirect the user to their profile page. If they don't and don't have an ECA on file, only then we ask then, we redirect them to sign the ECA form.

That is not TRUE, we do check if the user has an MCCA OR ICA: https://gitlab.eclipse.org/eclipsefdn/it/websites/drupal/site_login/-/blob/7.x-4.x/site_login_accounts/site_login_accounts.module#L355

added Drupal 9 label

assigned to @cguindon and unassigned @epoirier

changed due date to December 20, 2023

Just one idea what could raise the problem: In the "Create your account" form there is a drop-down field called "Eclipse Member Organization" (in case you select "Work for an Eclipse Member Organization" under "What is your employment status"). This drop-down field contains all direct EF members, but not the associated affiliates (and we can't solve this at this level). So there may a situation where a developer directly from Mercedes wants to register but only finds "Mercedes Benz Tech Innovation Gmbh" in the drop down list. As he may not be aware of our affiliate regulations he may assume that he needs to choose a different option (like "Others") and ends up with the request to sign an ECA.

@mplagge I am wondering if the root of the problem that Mercedes is experiencing is because of this issue: #95

If so, I would recommend that we close this issue and try to fix this problem via #95

removed Drupal 9 label

mentioned in issue #95

added statein discussion label and removed statetodo label

removed due date December 20, 2023

Hi @cguindon

I personally think this issue and issue #95 are describing different scenarios. #95 describes the "wrong" behaviour of a user, while this issue describes the "wrong" behaviour of the system. But I can see how fixing #95 may also help to solve this issue. However at least I want to ask you to spent a final thought if solving #95 really solves this issue as well

Hi @mplagge,

I understand your point of view.

I will dedicate some time to this task today to do some more thorough testing to confirm if there is a problem with the system and see if there is something I could do to fix the issue.

If the system is not behaving as we expect it to, then we need to fix it before my team completes the migration of the account website to Drupal 9.

I've identified the root cause of the issue.

In summary, the problem occurs when a new user from a member company logs in for the first time. Our system will try to add an EMPLOYEE relation with that member in the foundation db. However, the process will fail if there's no existing People record in the foundationdb.

To address this, I've made a patch to the Drupal 7 updateUserOrganization() method to ensure a People record always exists (it will create it if not existent) before updating the OrganizationContact table.

https://gitlab.eclipse.org/eclipsefdn/it/websites/drupal/site_login/-/merge_requests/56/diffs

added statewip label and removed statein discussion label

changed due date to December 20, 2023

added statereview label and removed statewip label

added statedone label and removed statereview label

closed

Closing this issue. I was able to confirm the fix by creating a new account that was associated with IBM. On my first login, I was not access to sign the ECA and my ECA status was valid.