Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • S solstice-assets
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
    • Locked files
  • Issues 36
    • Issues 36
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
    • Requirements
  • Merge requests 12
    • Merge requests 12
  • Deployments
    • Deployments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • Code review
    • Insights
    • Issue
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar
  • Eclipse FoundationEclipse Foundation
  • IT
  • Webdev
  • solstice-assets
  • Merge requests
  • !180

need important and no need for fit-content

  • Review changes

  • Download
  • Patches
  • Plain diff
Merged Christopher Guindon requested to merge github/fork/flora8984461/yiliu/master/updateMembershipStyle into master Oct 06, 2020
  • Overview 3
  • Commits 2
  • Changes 3

Created by: flora8984461

Do need "!important" for no-gutters-mobile, otherwise it will be overridden by paddings classes, and I removed fit-content since no need for it if the paddings are removed.

I find I can remove the "padding-right-40" and "padding-left-40" since the class ".content-nav-tab-body." and "tab-content" gives a padding 40 on big screen and a padding 10 on mobile view.

@chrisguindon I wonder if you like to keep the 10 paddings on the mobile view? - If so, we do not need to add any new classes as long as the screen is bigger than 360px. The following are the view with 10 paddings: ( You can see, with 10 paddings and without fit-content, the button would be a little bit ugly on size 360px. ) image image

this following is a wider mobile with 375px: ( You can see, with 10 paddings and without fit-content, the button is good on size 375px. ) image

If you prefer to use 0 paddings, then we probably need this no-gutters-mobile class.

Signed-off-by: Yi Liu yi.liu@eclipse-foundation.org

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/flora8984461/yiliu/master/updateMembershipStyle

Copyright © Eclipse Foundation, Inc. All Rights Reserved.     Privacy Policy | Terms of Use | Copyright Agent