LGTM, I'll leave it to Olivier to approve as he had some comments
I mean to add your videoId control to the existing "Video Embed" and "Playlist Embed" stories. One video per story.
you mean, in the same stories but as a different widget? resulting in two videos per story
yep, that's a fair point, I can add that check
It's a very nice improvement @gnugomez!...
I don't find this feature complex enough to warrant a separate story. IMO, the id arg should be incorporated into the two existing stories....
I know this logic already exists in the current code, but it seems too risky to insert a URL directly into an iframe without at least validating th...
Yes, we should continue supporting the previous usage @gnugomez
@oliviergoulet do we want to introduce this change in a non-breaking way? so that the previous usage is also available.
awesome thanks for the context
We have a video embed component that can be used like so:...
@oliviergoulet Could you expand a little bit what needs to be done here? it's not looking clear for me. Thanks