Skip to content
Snippets Groups Projects

Added modal JS to webpack code

Merged Ghost User requested to merge github/fork/autumnfound/malowe/master/modal into master

Signed-off-by: Martin Lowe martin.lowe@eclipse-foundation.org

Merge request reports

Approval is optional

Merged by Christopher GuindonChristopher Guindon 4 years ago (May 5, 2020 7:53pm UTC)

Merge details

  • Changes merged into master with d71baa4f.
  • Deleted the source branch.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • I see this as a phase 1 of modal additions to the solstice assets. For phase 2, I could see us adding a mustache template as an optional render of the modal interior. This will give us more flexibility around data that is written to the page.

    We could load attributes in via a data() call on the related target, and adding the body to the returned object as we do currently. This object would be passed into the mustache engine and render the modal content on the fly. This would allow us to reuse the singular modal container for any pop out across the site.

  • Christopher Guindon
  • Christopher Guindon
  • Ghost User
  • Please register or sign in to reply
    Loading