Skip to content
Snippets Groups Projects

Iss #70 - Add bypass for fork projects in oniro-core

Merged Iss #70 - Add bypass for fork projects in oniro-core
1 unresolved thread
Merged Martin Lowe requested to merge (removed):malowe/master/70 into master
1 unresolved thread

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • requested review from @cguindon, @epoirier, and @zacharysabourin

  • Author Maintainer

    Test case; Used meta-clang which exists in the allow list and meta-dang which does not:

    ❯ git push
    Username for 'http://localhost': root
    Password for 'http://root@localhost': 
    Enumerating objects: 5, done.
    Counting objects: 100% (5/5), done.
    Delta compression using up to 8 threads
    Compressing objects: 100% (2/2), done.
    Writing objects: 100% (3/3), 289 bytes | 289.00 KiB/s, done.
    Total 3 (delta 0), reused 0 (delta 0), pack-reused 0
    remote: Found allow listed project, skipping validation
    remote: 
    remote: To create a merge request for malowe/main/1, visit:
    remote:   http://localhost/eclipse/oniro-core/meta-clang/-/merge_requests/new?merge_request%5Bsource_branch%5D=malowe%2Fmain%2F1
    remote: 
    To http://localhost/eclipse/oniro-core/meta-clang.git
       bb4e5b1..e3d5ad6  malowe/main/1 -> malowe/main/1
    ❯ git push origin HEAD -u
    Username for 'http://localhost': root
    Password for 'http://root@localhost': 
    Enumerating objects: 3, done.
    Counting objects: 100% (3/3), done.
    Writing objects: 100% (3/3), 221 bytes | 221.00 KiB/s, done.
    Total 3 (delta 0), reused 0 (delta 0), pack-reused 0
    remote: Commit: 26a62a26d1c93957daf625d7fd8b3c17206996f3		✔
    remote: 
    remote: 	Reviewing commit: 26a62a26d1c93957daf625d7fd8b3c17206996f3
    remote: 	Authored by: Martin Lowe <martin.lowe@eclipse-foundation.org>
    remote: 	Eclipse user 'malowe'(author) is not a committer on the project.
    remote: 	Eclipse user 'malowe'(author) has a current Eclipse Contributor Agreement (ECA) on file.
    remote: 	Eclipse user 'malowe'(committer) is not a committer on the project.
    remote: 	Eclipse user 'malowe'(committer) has a current Eclipse Contributor Agreement (ECA) on file.
    remote: 
    remote: 
    remote: More information is available at https://api.eclipse.org/git/eca/status/8192d17f63f16fc9563734b51a26819d/ui
    To http://localhost/eclipse/oniro-core/meta-dang.git
     * [new branch]      HEAD -> malowe/main/1
    branch 'malowe/main/1' set up to track 'origin/malowe/main/1'.
88 102 if (nil_or_empty(project_url)) then
89 103 puts "Could not determine a web URL for project, likely not a fully-qualified project, skipping"
90 104 exit 0
105 elsif (ALLOW_LIST_PROJECTS.any? {|repo_namespace| project_url.end_with? repo_namespace}) then
  • Martin Lowe added 1 commit

    added 1 commit

    • e7067b04 - Updated to use very strict bypass for oniro-core checks

    Compare with previous version

  • Author Maintainer

    Test with new code:

    ❯ git push
    Username for 'http://localhost': root
    Password for 'http://root@localhost': 
    Enumerating objects: 5, done.
    Counting objects: 100% (5/5), done.
    Writing objects: 100% (3/3), 258 bytes | 258.00 KiB/s, done.
    Total 3 (delta 0), reused 0 (delta 0), pack-reused 0
    remote: Commit: 335203445eca470b32669f285e181c85f857890f		✔
    remote: 
    remote: 	Reviewing commit: 335203445eca470b32669f285e181c85f857890f
    remote: 	Authored by: Martin Lowe <martin.lowe@eclipse-foundation.org>
    remote: 	Eclipse user 'malowe'(author) is not a committer on the project.
    remote: 	Eclipse user 'malowe'(author) has a current Eclipse Contributor Agreement (ECA) on file.
    remote: 	Eclipse user 'malowe'(committer) is not a committer on the project.
    remote: 	Eclipse user 'malowe'(committer) has a current Eclipse Contributor Agreement (ECA) on file.
    remote: 
    remote: 
    remote: More information is available at https://api.eclipse.org/git/eca/status/18cb94e6f94856add338397723c313f9/ui
    To http://localhost/eclipse/oniro-core/meta-dang.git
       26a62a2..3352034  malowe/main/1 -> malowe/main/1
    ❯ cd ../meta-clang
    ❯ vim test.txt
    ❯ git add .
    ❯ git commit -m "Tests"
    [malowe/main/1 37d98ea] Tests
     1 file changed, 1 insertion(+), 1 deletion(-)
    ❯ git push
    Username for 'http://localhost': root
    Password for 'http://root@localhost': 
    Enumerating objects: 5, done.
    Counting objects: 100% (5/5), done.
    Delta compression using up to 8 threads
    Compressing objects: 100% (2/2), done.
    Writing objects: 100% (3/3), 296 bytes | 296.00 KiB/s, done.
    Total 3 (delta 0), reused 0 (delta 0), pack-reused 0
    remote: Found allow listed project, skipping validation
    remote: 
    remote: To create a merge request for malowe/main/1, visit:
    remote:   http://localhost/eclipse/oniro-core/meta-clang/-/merge_requests/new?merge_request%5Bsource_branch%5D=malowe%2Fmain%2F1
    remote: 
    To http://localhost/eclipse/oniro-core/meta-clang.git
       e3d5ad6..37d98ea  malowe/main/1 -> malowe/main/1
  • Christopher Guindon approved this merge request

    approved this merge request

  • merged

  • Martin Lowe mentioned in commit a1a2d15b

    mentioned in commit a1a2d15b

  • Please register or sign in to reply
    Loading