Add DB impl for validation state storage
Merge request reports
Activity
added 1 commit
- 20ef017c - Add commit groups and basic UI for displaying commit groups
added 1 commit
- edd3b8eb - Update testing and test API stubs, fix minor issues w/ commit groups
Tests now pass in CI, so this is ready for review. It's a big-ish patch, but some of it can be ignored. There are 2 template files for eclipse-header and eclipse-footer as they are copy-paste from solstice assets with a few tweaks to work in the template engine. The user service and validation service are parts of what was in the ValidationResource split out to make cleaner testing and reuse if needed in the future. These services also now have additional unit tests to make double sure the logic works as intended.
Edited by Martin Loweadded 1 commit
- c4f1eacd - Update openapi spec for ECA response, and added commit status endpoint
requested review from @heurtemattes
@heurtemattes I added you to this as I was told that you have Java experience in the past and might be able to help with reviews! Our newgrad java dev is joining on Weds, so hopefully I won't be pinging you for very long ;)
- config/mariadb/init.sql 0 → 100644
1 CREATE TABLE `CommitValidationMessage` ( 2 `id` int(11) NOT NULL AUTO_INCREMENT, 3 `commit_id` int(11) NOT NULL, changed this line in version 6 of the diff
- Resolved by Sébastien Heurtematte
- Resolved by Martin Lowe
- Resolved by Martin Lowe
- Resolved by Martin Lowe
32 33 public CommitValidationStatusGrouping(String fingerprint, CommitValidationStatus commit) { 34 this.compositeId = new GroupingCompositeId(); 35 this.compositeId.setFingerprint(fingerprint); 36 this.compositeId.setCommit(commit); 37 } 38 39 @Override 40 public GroupingCompositeId getId() { 41 return compositeId; 42 } 43 44 /** 45 * @return the compositeId 46 */ 47 public GroupingCompositeId getCompositeId() { - Resolved by Sébastien Heurtematte
- Resolved by Sébastien Heurtematte
- Resolved by Sébastien Heurtematte