Make the commit list more robust

Uses git rev-list instead of git cherry to list commits. This has the option to ignore known/non-new commits which should reduce the noise in the console. Additionally, updated to use better checks for skipping certain events (like deletion events) and rely on the write perms instead.

requested review from @cguindon, @fgurr, and @mbarbero

"Commit is a deletion of a branch": I feel this message might be confusing to the end-user if they are simply pushing a new tag. How about something like:

No new commits found, nothing to validate.

Also, will this validate commits if the user is pushing a new branch?

This is only if the new head is zeroed, so they are pushing a deletion. This would never impact new branches with actual data.

Also more context, the following line is how we detect new branches: !69 (572ac132)

changed this line in version 3 of the diff

approved this merge request

added 1 commit

• 572ac132 - Update eca ruby script to clean \r and validate all new commits

Compare with previous version

mentioned in issue eclipsefdn/helpdesk#869 (closed)

resolved all threads

approved this merge request

added 1 commit

• ba05c057 - Revert newline fix to be committed in new branch

Compare with previous version

For testing purposes, would it be simple to run this on port 80 without SSL?

Also, are you sure these environment variables are needed? I would expect them to be useful when using something like https://github.com/nginx-proxy/nginx-proxy

This is a standalone thing and I'm just going off of the instructions from Gitlab. If you want to add that to the stack we can in the future but I don't think it should block these changes

GITLAB_OMNIBUS_CONFIG seems to be the only required env variable needed: GITLAB_OMNIBUS_CONFIG

I think the rest is from you copy-pasting the content of docker-compose file in our project. Granted, these won't hurt the project if they are not required.

changed this line in version 4 of the diff

added 1 commit

• 3c72c0e4 - Update docker-compose to remove unneeded env vars

Compare with previous version

approved this merge request

closed