Change bot detection logic and add tests around bot detection in API

Added tests for all 3 supported platforms (Github, Gitlab, and Gerrit) around bot detection. Changed bot detection policy to check if user is any bot, regardless of project commit is for. This allows for bots to push in untracked projects when using strict mode as well.

Signed-off-by: Martin Lowe martin.lowe@eclipse-foundation.org

@mbarbero the email change is due to an encoding issue we discovered today around how drupal handles + symbols. To make sure data is properly encoded, I'm encoding in the API rather than relying on the incoming data. This avoids more churn in the plugin and in the ruby script on production for Gitlab, and means that the root is taken care of and valid.

Update: With testing with the real fix rather than simulated locally, only the accounts API fix was needed. I've removed my fix as it actually broke it with the other fix.

Created by mbarbero

Review: Approved