Change that will bypass committer check if not a PMI project

Currently this causes issues on internal checks, but could cause issues rebasing in some scenarios in other environments.

Signed-off-by: Martin Lowe martin.lowe@eclipse-foundation.org

Manual test performed locally to accurately reproduce issue. When removing .fake, the repo URL registers as a real project and fails as expected.

Sent:

{
   "repoUrl":"/gitroot/e4/eclipse.platform.runtime.e4.fake",
   "commits":[
      {
         "hash":"b0e9ff84a121fb3e468c56fda8d1fe44ed1c2864",
         "subject":"Test",
         "body":"Test Change-Id: Ice1eb2f662dc9f83cba25ef23a4d600a903b969f\nSigned-off-by: Martin Lowe <martin.lowe@eclipse-foundation.org>",
         "parents":[
            ""
         ],
         "author":{
            "name":"Martin Lowe",
            "mail":"martin.lowe@eclipse-foundation.org"
         },
         "committer":{
            "name":"Martin Lowe",
            "mail":"chris.guindon@eclipse-foundation.org"
         },
         "head":true
      }
   ],
   "provider":"gerrit",
	"strictMode": true
}

Recieved:

{
  "passed": true,
  "errorCount": 0,
  "time": 1607695764375,
  "commits": {
    "b0e9ff84a121fb3e468c56fda8d1fe44ed1c2864": {
      "messages": [
        {
          "code": 200,
          "message": "Reviewing commit: b0e9ff84a121fb3e468c56fda8d1fe44ed1c2864"
        },
        {
          "code": 200,
          "message": "Authored by: Martin Lowe <martin.lowe@eclipse-foundation.org>"
        },
        {
          "code": 200,
          "message": "The author is not a committer on the project."
        },
        {
          "code": 200,
          "message": "The author has a current Eclipse Contributor Agreement (ECA) on file."
        },
        {
          "code": 200,
          "message": "The author has signed-off on the contribution."
        }
      ],
      "warnings": [],
      "errors": []
    }
  },
  "trackedProject": false,
  "strictMode": true
}

approved this merge request

Created by mbarbero

Review: Commented

lgtm. Please, refresh my mind on what is the meaning for a ValidationResponse to return true to isTrackedProject().

lgtm. Please, refresh my mind on what is the meaning for a ValidationResponse to return true to isTrackedProject().

Tracked project means that it matched on a PMI project via the repoURL, and can be matched for bots and committers. Since a non-tracked project will never have committers, we shouldn't check if the committer is a Committer

Created by mbarbero

Review: Approved