Update to pagination service to scrub .git from Gerrit repo URLs

Reformatted, only change is in getProjectsInternal

src/main/java/org/eclipsefoundation/git/eca/service/impl/PagintationProjectsService.java

-/*******************************************************************************
+/**
* Copyright (C) 2020 Eclipse Foundation
- * 
- * This program and the accompanying materials are made
- * available under the terms of the Eclipse Public License 2.0
- * which is available at https://www.eclipse.org/legal/epl-2.0/
- * 
+ *
+ * This program and the accompanying materials are made available under the terms of the Eclipse
+ * Public License 2.0 which is available at https://www.eclipse.org/legal/epl-2.0/
+ *
* SPDX-License-Identifier: EPL-2.0
- ******************************************************************************/
+ */
package org.eclipsefoundation.git.eca.service.impl;
import java.util.LinkedList;
@@ -36,106 +35,115 @@ import com.google.common.util.concurrent.ListenableFutureTask;
import io.quarkus.runtime.Startup;
/**
- * Projects service implementation that handles pagination of data manually, as
- * well as makes use of a loading cache to have data be always available with as
- * little latency to the user as possible.
- * 
+ * Projects service implementation that handles pagination of data manually, as well as makes use of
+ * a loading cache to have data be always available with as little latency to the user as possible.
+ *
* @author Martin Lowe
*/
@Startup
@ApplicationScoped
public class PagintationProjectsService implements ProjectsService {
-	private static final Logger LOGGER = LoggerFactory.getLogger(PagintationProjectsService.class);
-
-	@Inject
-	ManagedExecutor exec;
-	@ConfigProperty(name = "cache.pagination.refresh-frequency-seconds", defaultValue = "3600")
-	long refreshAfterWrite;
-	
-	@Inject
-	@RestClient
-	ProjectsAPI projects;
-	// this class has a separate cache as this data is long to load and should be
-	// always available.
-	LoadingCache<String, List<Project>> internalCache;
-	/**
-	 * Initializes the internal loader cache and pre-populates the data with the one
-	 * available key. If more than one key is used, eviction of previous results
-	 * will happen and create degraded performance.
-	 */
-	@PostConstruct
-	public void init() {
-		// set up the internal cache
-		this.internalCache = CacheBuilder.newBuilder().maximumSize(1).refreshAfterWrite(refreshAfterWrite, TimeUnit.SECONDS)
-				.build(new CacheLoader<String, List<Project>>() {
-					@Override
-					public List<Project> load(String key) throws Exception {
-						return getProjectsInternal();
-					}
-					/**
-					 * Implementation required for refreshAfterRewrite to be async rather than sync
-					 * and blocking while awaiting for expensive reload to complete.
-					 */
-					@Override
-					public ListenableFuture<List<Project>> reload(String key, List<Project> oldValue) throws Exception {
-						ListenableFutureTask<List<Project>> task = ListenableFutureTask.create(() -> {
-							LOGGER.debug("Retrieving new project data async");
-							List<Project> newProjects = oldValue;
-							try {
-								newProjects = getProjectsInternal();
-							} catch (Exception e) {
-								LOGGER.error(
-										"Error while reloading internal projects data, data will be stale for current cycle.",
-										e);
-							}
-							LOGGER.debug("Done refreshing project values");
-							return newProjects;
-						});
-						// run the task using the Quarkus managed executor
-						exec.execute(task);
-						return task;
-					}
-				});
-		// pre-cache the projects to reduce load time for other users
-		LOGGER.debug("Starting pre-cache of projects");
-		if (getProjects() == null) {
-			LOGGER.warn(
-					"Unable to populate pre-cache for Eclipse projects. Calls may experience degraded performance.");
-		}
-		LOGGER.debug("Completed pre-cache of projects assets");
-	}
-	@Override
-	public List<Project> getProjects() {
-		try {
-			return internalCache.get("projects");
-		} catch (ExecutionException e) {
-			throw new RuntimeException("Could not load Eclipse projects", e);
-		}
-	}
-	/**
-	 * Logic for retrieving projects from API. Will loop until there are no more
-	 * projects to be found
-	 * 
-	 * @return list of projects for the
-	 */
-	private List<Project> getProjectsInternal() {
-		int page = 0;
-		int pageSize = 100;
-		List<Project> out = new LinkedList<>();
-		List<Project> in;
-		do {
-			page++;
-			in = projects.getProject(page, pageSize);
-			out.addAll(in);
-		} while (in != null && !in.isEmpty());
-		return out;
-	}
+  private static final Logger LOGGER = LoggerFactory.getLogger(PagintationProjectsService.class);
+  @Inject ManagedExecutor exec;
+  @ConfigProperty(name = "cache.pagination.refresh-frequency-seconds", defaultValue = "3600")
+  long refreshAfterWrite;
+  @Inject @RestClient ProjectsAPI projects;
+  // this class has a separate cache as this data is long to load and should be
+  // always available.
+  LoadingCache<String, List<Project>> internalCache;
+  /**
+   * Initializes the internal loader cache and pre-populates the data with the one available key. If
+   * more than one key is used, eviction of previous results will happen and create degraded
+   * performance.
+   */
+  @PostConstruct
+  public void init() {
+    // set up the internal cache
+    this.internalCache =
+        CacheBuilder.newBuilder()
+            .maximumSize(1)
+            .refreshAfterWrite(refreshAfterWrite, TimeUnit.SECONDS)
+            .build(
+                new CacheLoader<String, List<Project>>() {
+                  @Override
+                  public List<Project> load(String key) throws Exception {
+                    return getProjectsInternal();
+                  }
+                  /**
+                   * Implementation required for refreshAfterRewrite to be async rather than sync
+                   * and blocking while awaiting for expensive reload to complete.
+                   */
+                  @Override
+                  public ListenableFuture<List<Project>> reload(String key, List<Project> oldValue)
+                      throws Exception {
+                    ListenableFutureTask<List<Project>> task =
+                        ListenableFutureTask.create(
+                            () -> {
+                              LOGGER.debug("Retrieving new project data async");
+                              List<Project> newProjects = oldValue;
+                              try {
+                                newProjects = getProjectsInternal();
+                              } catch (Exception e) {
+                                LOGGER.error(
+                                    "Error while reloading internal projects data, data will be stale for current cycle.",
+                                    e);
+                              }
+                              LOGGER.debug("Done refreshing project values");
+                              return newProjects;
+                            });
+                    // run the task using the Quarkus managed executor
+                    exec.execute(task);
+                    return task;
+                  }
+                });
+    // pre-cache the projects to reduce load time for other users
+    LOGGER.debug("Starting pre-cache of projects");
+    if (getProjects() == null) {
+      LOGGER.warn(
+          "Unable to populate pre-cache for Eclipse projects. Calls may experience degraded performance.");
+    }
+    LOGGER.debug("Completed pre-cache of projects assets");
+  }
+  @Override
+  public List<Project> getProjects() {
+    try {
+      return internalCache.get("projects");
+    } catch (ExecutionException e) {
+      throw new RuntimeException("Could not load Eclipse projects", e);
+    }
+  }
+  /**
+   * Logic for retrieving projects from API. Will loop until there are no more projects to be found
+   *
+   * @return list of projects for the
+   */
+  private List<Project> getProjectsInternal() {
+    int page = 0;
+    int pageSize = 100;
+    List<Project> out = new LinkedList<>();
+    List<Project> in;
+    do {
+      page++;
+      in = projects.getProject(page, pageSize);
+      in.forEach(
+          proj ->
+              proj.getGerritRepos()
+                  .forEach(
+                      repo -> {
+                        if (repo.getUrl().endsWith(".git")) {
+                          repo.setUrl(repo.getUrl().substring(0, repo.getUrl().length() - 4));
+                        }
+                      }));
+      out.addAll(in);
+    } while (in != null && !in.isEmpty());
+    return out;
+  }
}