Update to ECA script to be smarter with reading in commits

Change from using rev-list to cherry for list of commits. Will remove commits already tracked in default branch from checked commits. This should prove to be more accurate than rev-list which did not respect boundaries of branches/tree.

Includes fix for new line characters being randomly added to output after switch over to using hash objects to store commit data directly.

Signed-off-by: Martin Lowe martin.lowe@eclipse-foundation.org

src/main/java/org/eclipsefoundation/git/eca/resource/ValidationResource.java

@@ -224,13 +224,13 @@ public class ValidationResource {
// retrieve the email of the Signed-off-by footer
String signedOffBy = CommitHelper.getSignedOffByEmail(c);
if (signedOffBy != null && signedOffBy.equalsIgnoreCase(eclipseAuthor.getMail())) {
-				addMessage(r, "The author has \"signed-off\" on the contribution.", c.getHash());
+				addMessage(r, "The author has signed-off on the contribution.", c.getHash());
} else {
addMessage(r,
-						"The author has not \"signed-off\" on the contribution.\n"
+						"The author has not signed-off on the contribution.\n"
+ "If there are multiple commits, please ensure that each commit is signed-off.",
c.getHash());
-				addError(r, "The contributor must \"sign-off\" on the contribution.", c.getHash(),
+				addError(r, "The contributor must sign-off on the contribution.", c.getHash(),
APIStatusCode.ERROR_SIGN_OFF);
}