Fix issue where 0'd commit sha isn't matching properly
- Fix issue where 0'd commit sha isn't matching properly
In local testing after reports by Matt + Denis, it was found the 0 matching regex wasn't behaving properly. This seems to be caused by ruby auto-casting a 0 only string to a number due to soft typing, which wasn't a problem observed before. The fix forces the var into a string before regex comparisons.
Merge request reports
Activity
requested review from @droy, @mward, @zacharysabourin, and @cguindon
Tested and reproducible with https://onlinegdb.com/9qTSzH1Ln
Shows previous functionality in sample 2, and current with 1 and 3.
mentioned in commit 10346317
@droy has this been deployed yet? I want to make sure before I do some tests to ensure the issue is resolved with this patch
mentioned in issue eclipsefdn/helpdesk#4747 (closed)