Add ability to allow list group namespaces to bypass ECA

• Add ability to allow list group namespaces to bypass ECA

This bypass is needed for migrating large existing Git repositories, as the ECA will time out on massive requests.

requested review from @cguindon, @malowe, and @zacharysabourin

Tested using https://www.onlinegdb.com/online_ruby_compiler with the following code snippet:

ALLOW_LIST_GROUPS = ['eclipsefdn/it/webdev/eclipse.org-php-archives/']
project_json_data = {
  "path_with_namespace" => 'eclipse/chess/chess/sample-repo'
}
puts "Test: #{project_json_data['path_with_namespace']}"
if (ALLOW_LIST_GROUPS.any? {|group_namespace| project_json_data['path_with_namespace'].start_with?(group_namespace)}) then
  puts "Found allow listed group, skipping validation"
else
  puts "nope"
end

More of an observation but we define projects with a slash at the start of the string but not groups?

It's due to how that check is done, as it uses a different method to check it which is less efficient. I didn't want to touch it since it's working, but this check should be a bit more robust as it doesn't rely on the host URL

approved this merge request

merged

mentioned in commit aec721c2

@mward in the future, if you're migrating large projects with long histories over, updating the ALLOW_LIST_GROUPS added here should make your job far easier. All you have to do is add the path leading to the group you are migrating, and everything under it should have the ECA check skipped.

I'll try to keep it in mind.

@droy sorry for the short turnaround, but there is an ECA script update. This adds the ability to bypass ECA for Gitlab groups designated in this file, with currently our new PHP site archive being the only set group. It should make a couple of our migration activities easier for larger projects as well.

@malowe can you remind me of the URI to download the latest ECA please?

The main branch raw file is here: https://gitlab.eclipse.org/eclipsefdn/it/api/git-eca-rest-api/-/raw/main/src/main/rb/eca.rb?ref_type=heads