Skip to content
GitLab
Explore
Sign in
Primary navigation
Search or go to…
Project
G
Git ECA API
Manage
Activity
Members
Labels
Plan
Issues
Issue boards
Milestones
Iterations
Wiki
Requirements
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Snippets
Locked files
Build
Pipelines
Jobs
Pipeline schedules
Test cases
Artifacts
Deploy
Releases
Model registry
Operate
Environments
Monitor
Incidents
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Code review analytics
Issue analytics
Insights
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Terms and privacy
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
Eclipse Foundation
IT
APIs
Git ECA API
Merge requests
!162
The source project of this merge request has been removed.
Iss
#148
- Update the revalidation queue to remove closed PRs from queue
Merged
Iss
#148
- Update the revalidation queue to remove closed PRs from queue
(removed):malowe/main/148
into
main
Overview
0
Commits
1
Pipelines
0
Changes
1
Merged
Martin Lowe
requested to merge
(removed):malowe/main/148
into
main
1 year ago
Overview
0
Pipelines
0
Changes
1
Expand
Previously, we had high frequency revalidations where the PR was closed, which will never pass.
0
0
Merge request reports
Compare
main
main (base)
and
latest version
latest version
2f8a2462
1 commit,
1 year ago
1 file
+
8
−
1
Inline
Compare changes
Side-by-side
Inline
Show whitespace changes
Show one file at a time
src/main/java/org/eclipsefoundation/git/eca/tasks/GithubRevalidationQueue.java
+
8
−
1
Options
@@ -137,8 +137,15 @@ public class GithubRevalidationQueue {
// log the message so we can see what happened
LOGGER
.
error
(
"Error while revalidating request w/ ID {}"
,
requestToRevalidate
.
getId
(),
e
);
}
finally
{
// whether successful or failed, update the updated field
// whether successful or failed, update the updated
time
field
requestToRevalidate
.
setLastUpdated
(
DateTimeHelper
.
now
());
// if in a closed state, we shouldn't try to revalidate again as it will never be valid
// if a PR is reopened, it should create a new event and validate anyways
if
(
"closed"
.
equalsIgnoreCase
(
requestToRevalidate
.
getLastKnownState
()))
{
LOGGER
.
debug
(
"Tracking request {} set to not revalidate as it was closed"
,
requestToRevalidate
.
getId
());
requestToRevalidate
.
setNeedsRevalidation
(
false
);
}
// push the update with the potentially updated validation flag or error count
dao
.
add
(
new
RDBMSQuery
<>(
wrap
,
filters
.
get
(
GithubWebhookTracking
.
class
)),
Arrays
.
asList
(
requestToRevalidate
));
}
Loading