Add error page for GH status validation page for bad requests
Merge request reports
Activity
requested review from @zacharysabourin and @cguindon
@cguindon Was doing final tests, and the GH ECA status page was returning blank for errors where there was no valid installation. I've added a basic error page to point users to the helpdesk in case they believe the page should have been rendered. This shouldn't come up during regular use, as anything with a link to this endpoint will be valid, and would only occur with manual entry of the URL.
- src/main/resources/templates/404.html 0 → 100644
1 {#include eclipse_header} 2 {#title}Git ECA Validation{/} 3 {/include} 4 {#include eclipse_breadcrumb /} 5 <div class="container" id="main-page-content"> 6 <div id="main-content-row" class="row"> 7 <section id="main-content" class="col-md-18 col-sm-16 margin-bottom-20"> 8 <h1>Git ECA Validation Status</h1> 9 <p>The requested ECA validation could not be served, as the data was deemed unable to be validated for the Eclipse Foundation projects namespaces.</p> changed this line in version 2 of the diff
Using repo outside of our install base (http://localhost:8080/git/eca/status/gh/microsoft/vscode/193369)
Using repo that doesn't exist (http://localhost:8080/git/eca/status/gh/eclipsefdn-webdev/Test-Access-Repos/85)
Attempt to revalidate closed PR (http://localhost:8080/git/eca/status/gh/eclipsefdn-webdev/Test-Access-Repo/86)
added 1 commit
- 305e023e - Add better handling of errors in GH status page for different cases
- Resolved by Zachary Sabourin
mentioned in commit c016af9e