Skip to content
Snippets Groups Projects

Iss #115 - Add a reprocessing queue for failed GH webhook calls

Merged Iss #115 - Add a reprocessing queue for failed GH webhook calls
All threads resolved!
Merged Martin Lowe requested to merge (removed):malowe/main/115 into main
All threads resolved!

To resolve an issue where some GH calls are timing out unexpectedly during validation, a new scheduled task was created, along with some updates to the DB models.

The new task uses the new revalidation flag on the tracking model to look up requests to see if they need to be revalidated, and rerun validation on the oldest set entry. When run, the last updated field will be updated regardless of success of validation. This will allow us to not get stuck on a single tracking request that is in a bad state potentially.

The DB model changes add 2 new fields to webhook tracking entries, allowing for tracking of if a scheduled revalidation needs to be run and how many times a given webhook validation needed to be rerun. This should give us both the flexibility to rerun as needed, manually flag errant entries, as well as capture data on how often this happens.

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Zachary Sabourin
  • Zachary Sabourin
  • Martin Lowe added 1 commit

    added 1 commit

    • f2817301 - Fix revalidation param value, disable revalidation task on test

    Compare with previous version

  • Martin Lowe resolved all threads

    resolved all threads

  • Zachary Sabourin approved this merge request

    approved this merge request

  • merged

  • Martin Lowe mentioned in commit 789ba5e6

    mentioned in commit 789ba5e6

  • Please register or sign in to reply
    Loading