Skip to content
Snippets Groups Projects

feat: Improve code quality

2 unresolved threads

Relates to #135 (closed)

Merge request reports

Merged by Martin LoweMartin Lowe 1 year ago (Aug 16, 2023 12:59pm UTC)

Loading

Pipeline #30579 passed

Pipeline passed for fd433fec on main

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • added 1 commit

    • 0f75048d - feat: Increase validation coverage

    Compare with previous version

  • added 1 commit

    • f609a5f1 - feat: Add basic test for GH hook endpoint

    Compare with previous version

  • added 1 commit

    Compare with previous version

  • Zachary Sabourin marked this merge request as ready

    marked this merge request as ready

  • Zachary Sabourin requested review from @malowe

    requested review from @malowe

  • 57 57
    58 58 ## Misc
    59 59 eclipse.system-hook.pool-size=5
    60
    61 ## Disable private project scan in test mode
    62 %test.eclipse.scheduled.private-project.enabled=false
  • Martin Lowe
  • 66 return PullRequest.builder().build();
    67 }
    68
    69 @Override
    70 public Response getCommits(String bearer, String apiVersion, String repoFull, int pullNumber) {
    71 List<GithubCommit> results = commits.get(repoFull).get(pullNumber);
    72 if (results == null && !results.isEmpty()) {
    73 return Response.status(404).build();
    74 }
    75 return Response.ok(results).build();
    76 }
    77
    78 @Override
    79 public Response updateStatus(String bearer, String apiVersion, String repoFull, String prHeadSha,
    80 GithubCommitStatusRequest commitStatusUpdate) {
    81 return Response.status(404).build();
  • added 1 commit

    Compare with previous version

  • Martin Lowe mentioned in issue #138

    mentioned in issue #138

  • added 1 commit

    • 2309796a - fix: Remove hcaptcha integrity check

    Compare with previous version

  • Martin Lowe approved this merge request

    approved this merge request

  • Martin Lowe mentioned in commit fd433fec

    mentioned in commit fd433fec

  • merged

  • Please register or sign in to reply
    Loading