Skip to content
Snippets Groups Projects

Added support for forks and untracked projects in API and pre-recieve

Closed Martin Lowe requested to merge github/fork/autumnfound/malowe/master/fork-support into master

Added logic to retrieve and check for information regarding parent project if fork. Added support in API + ECA script for untracked/managed projects.

Signed-off-by: Martin Lowe martin.lowe@eclipse-foundation.org

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Created by mbarbero

    Review: Approved

  • Author Maintainer

    @mbarbero I've added an environment variable to fetch the secret (for now) in the ruby file. I want to know if we should be doing what we are doing in the sync script and reading a file for that content instead. Once I know that I'll update the kubernetes descriptor file accordingly

  • Created by: mbarbero

    @mbarbero I've added an environment variable to fetch the secret (for now) in the ruby file. I want to know if we should be doing what we are doing in the sync script and reading a file for that content instead. Once I know that I'll update the kubernetes descriptor file accordingly

    I like to have secrets in file rather than environment variable as it's easier to find out who has access to the file. Also, secrets in files can be updated without requiring to restart the app (if the app is able to reload the file of course) while with an env, one need to restart the process to re-read the environment.

  • Author Maintainer

    @mbarbero I've added an environment variable to fetch the secret (for now) in the ruby file. I want to know if we should be doing what we are doing in the sync script and reading a file for that content instead. Once I know that I'll update the kubernetes descriptor file accordingly

    I like to have secrets in file rather than environment variable as it's easier to find out who has access to the file. Also, secrets in files can be updated without requiring to restart the app (if the app is able to reload the file of course) while with an env, one need to restart the process to re-read the environment.

    Alright, I'll work on adding support for that. I'll close this for now to make it easier and reopen it once that change is done (it might not be until tomorrow due to TZ)

Please register or sign in to reply
Loading