feat: Add new column to PrivateProjectEvent table for EF username
1 unresolved thread
resolves #105 (closed)
Merge request reports
Activity
Filter activity
65 65 @Override 66 66 public void processProjectCreateHook(RequestWrapper wrapper, SystemHook hook) { 67 67 if (hook != null) { 68 managedExecutor.execute(() -> trackPrivateProjectCreation(wrapper, hook)); 68 managedExecutor.runAsync(() -> { 69 try { 70 // Wait for a bit to allow GL to fully create the project before querying 71 Thread.sleep(200); 72 } catch (InterruptedException e) { 73 e.printStackTrace(); Print stack trace isn't what you should do here. InterruptedExceptions aren't something you should stop from propagating, and its a major bug w/ explanation from Sonarlint. Your method should throw InterruptedException and fail for that call if that's the case with a log to say it wasn't completed in a warn. This is why we have the catchup task after all!
changed this line in version 2 of the diff
added 1 commit
- 5fb3c6df - feat: Implement scheduled executor for HookService
added 1 commit
- e63c9abe - feat: Change username setting in creation process
mentioned in commit c4bcf571
Please register or sign in to reply