Iss #84 - Update git hook to enable fork validation

Resolves #84 (closed)

@cguindon this would theoretically enable all fork projects to validate. Do we want to block the commit if it fails, or allow it?

The goal here is to give more information to the user to help them better understand possible validation issues with their MR before they try to merge.

Let's allow on form and add more info.

So forks are a soft fail, in that they still allow the commit through with errors. In that case, we add an additional line that this commit will not be able to be merged until the issues noted are resolved. Is that correct?

Yes which should be the same as what we are doing now. The only difference with this issue is that I want the user to be able to know early that there is going to validation error if they try to merge this upstream. +1 for adding a line to that affect.

added 1 commit

• 2874cc0c - Update eca.rb to not fail on forked projects

Compare with previous version

marked this merge request as ready

Example message I scrapped from using this on my local:

remote: Fork detected, using forked from project's URL for better commit validation.
remote: Commit: 2d65b6d9a8a3bc2b8b2b510635bec2987641eeaf		~
remote: 
remote: 	Reviewing commit: 2d65b6d9a8a3bc2b8b2b510635bec2987641eeaf
remote: 	Authored by: Martin Lowe <author@eclipse.org>
remote: 	Could not find an Eclipse user with mail 'author@eclipse.org' for author of commit 2d65b6d9a8a3bc2b8b2b510635bec2987641eeaf
remote: 
remote: Warnings:
remote: 	Author must have an Eclipse Account
remote: Any warnings or errors noted above may indicate compliance issues with committer ECA requirements. More information may be found on https://www.eclipse.org/legal/ECA.php
remote: 
remote: 
remote: GL-HOOK-ERR: More information is available at https://api.eclipse.org/git/eca/status/8a7da94c919e99cfc029951c9fba6536/ui
remote: Errors or warnings were encountered while validating sign-off in current request for non-project repository.
remote: 
remote: Validation is currently not required for non-project repositories, continuing.

Any concerns?

I think that's good Martin! Thanks

mentioned in commit d5428cc5

merged