Skip to content
Snippets Groups Projects

feat: Create initial endpoint and add all supporting elements

Merged Zachary Sabourin requested to merge dev into master
  • Creates a table for tracking private project creation/deletion
  • Creates the initial endpoint, service, and tests

Resolves #79 (closed)

Resolves #78 (closed)

Edited by Zachary Sabourin

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
26 26 PRIMARY KEY (`commit_id`,`fingerprint`)
27 27 );
28 28
29 CREATE TABLE `PrivateProjectEvent` (
30 `userId` varchar(63) NOT NULL,
  • I am fine with this db name!

    I do have some nitpicking feedback:

    I am thinking we should rename userId varchar(63) to eclipseId varchar(255) to be consistent with CommitValidationMessage table. I am assuming that eclipseId is for storing the userid. If not, please ignore this comment.

    Same for dateCreated, I am thinking we should use creationDate for the same reason.

    If we do so, dateDeleted could also be deleted to match the previous format: deletedDate.

    I do like how you named your column but since we already have tables in the project I would prefer that we stay consistent on the project.

    WDYT?

    Edited by Christopher Guindon
  • Zachary Sabourin changed this line in version 6 of the diff

    changed this line in version 6 of the diff

  • Please register or sign in to reply
  • Zachary Sabourin added 2 commits

    added 2 commits

    • 304ea7aa - feat: Create starting point for hook processing
    • c060f67e - Merge branch 'dev' of gitlab.eclipse.org:eclipsefdn/it/api/git-eca-rest-api...

    Compare with previous version

  • Zachary Sabourin changed the description

    changed the description

  • Zachary Sabourin marked this merge request as draft

    marked this merge request as draft

  • Zachary Sabourin changed title from Draft: feat: Add event hook tracking table to script to Draft: feat: Create initial endpoint and add all supporting elements

    changed title from Draft: feat: Add event hook tracking table to script to Draft: feat: Create initial endpoint and add all supporting elements

  • Zachary Sabourin changed the description

    changed the description

  • added 1 commit

    • 304637da - feat: Add missing scope annotation on hook service

    Compare with previous version

  • added 1 commit

    • 9ef3f555 - feat: javadoc + json body conversion

    Compare with previous version

  • Zachary Sabourin added 2 commits

    added 2 commits

    • 3d62463f - feat: Add GL API client and /projects method
    • 99f6a30e - feat: Create initial hook processing steps

    Compare with previous version

  • added 1 commit

    • a5ff24b7 - feat: update userid and projectId to int

    Compare with previous version

  • added 1 commit

    • 9880d13a - fix: Adjust header and event type values

    Compare with previous version

  • added 1 commit

    • 8824becc - feat: point GL restclient to dev container

    Compare with previous version

  • Zachary Sabourin added 2 commits

    added 2 commits

    • 6529aea3 - feaet: Add access token to GL client
    • 3afcb360 - feat: Add dto mapper method

    Compare with previous version

  • Zachary Sabourin added 14 commits

    added 14 commits

    • 3afcb360...eb077790 - 2 commits from branch master
    • c9f6f691 - feat: Create starting point for hook processing
    • 468576b2 - feat: Add event hook tracking table to script
    • 276e5c9a - feat: Add missing scope annotation on hook service
    • 5cdae49d - feat: javadoc + json body conversion
    • 69f4d3d9 - feat: Add GL API client and /projects method
    • cfb1af53 - feat: Create initial hook processing steps
    • 8b6c3bec - feat: update userid and projectId to int
    • b7f0e7b7 - fix: Adjust header and event type values
    • c7e243e3 - feat: point GL restclient to dev container
    • 9845f569 - feaet: Add access token to GL client
    • 782f244b - feat: Add dto mapper method
    • c1b9c180 - fixing merge issues

    Compare with previous version

  • added 1 commit

    • 89bc6e02 - fix: Add exists condition to new table

    Compare with previous version

  • Zachary Sabourin added 2 commits

    added 2 commits

    • 3205f189 - fix: Add missing annotations
    • b787f9da - fix: Adjust hook validation condition

    Compare with previous version

  • Zachary Sabourin added 3 commits

    added 3 commits

    • 88dcfe73 - fix: change to docker compose
    • d845eabe - feat: Create project event DTO
    • 7927ac7a - feat: add dto mapping in hook service

    Compare with previous version

  • added 1 commit

    • 1543099c - feat: add initial db connectivity

    Compare with previous version

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading