feat: Create initial endpoint and add all supporting elements
- Creates a table for tracking private project creation/deletion
- Creates the initial endpoint, service, and tests
Resolves #79 (closed)
Resolves #78 (closed)
Merge request reports
Activity
requested review from @malowe, @cguindon, and @heurtemattes
@cguindon Let me know if you would prefer that I use a different table name
26 26 PRIMARY KEY (`commit_id`,`fingerprint`) 27 27 ); 28 28 29 CREATE TABLE `PrivateProjectEvent` ( 30 `userId` varchar(63) NOT NULL, I am fine with this db name!
I do have some nitpicking feedback:
I am thinking we should rename
userId
varchar(63) toeclipseId
varchar(255) to be consistent with CommitValidationMessage table. I am assuming that eclipseId is for storing the userid. If not, please ignore this comment.Same for dateCreated, I am thinking we should use creationDate for the same reason.
If we do so, dateDeleted could also be deleted to match the previous format: deletedDate.
I do like how you named your column but since we already have tables in the project I would prefer that we stay consistent on the project.
WDYT?
Edited by Christopher Guindonchanged this line in version 6 of the diff
added 1 commit
- 304637da - feat: Add missing scope annotation on hook service
added 2 commits
added 14 commits
-
3afcb360...eb077790 - 2 commits from branch
master
- c9f6f691 - feat: Create starting point for hook processing
- 468576b2 - feat: Add event hook tracking table to script
- 276e5c9a - feat: Add missing scope annotation on hook service
- 5cdae49d - feat: javadoc + json body conversion
- 69f4d3d9 - feat: Add GL API client and /projects method
- cfb1af53 - feat: Create initial hook processing steps
- 8b6c3bec - feat: update userid and projectId to int
- b7f0e7b7 - fix: Adjust header and event type values
- c7e243e3 - feat: point GL restclient to dev container
- 9845f569 - feaet: Add access token to GL client
- 782f244b - feat: Add dto mapper method
- c1b9c180 - fixing merge issues
Toggle commit list-
3afcb360...eb077790 - 2 commits from branch
added 2 commits