ECA validation error

marked the checklist item High as completed

marked the checklist item Major as completed

marked the checklist item High as incomplete

marked the checklist item Major as incomplete

changed the description

@rahulmoh I don't think that bot content is anything that can have an ECA, so if this is the only thing I would assume it is ready to merge, but the check should of course work and this was the case in the past.

What seem to be different now is that github-bot is also mentioned as the commiter, while the eclipse-bot is the author.

I appreciate your assessment. It seems that bot content might not have an ECA requirement(but this is act as committer). If this is the only consideration, I assume it's ready to be merged.

However, it's crucial that the checks are in working order, as has been the case in the past.

@rahulmoh if its crucial for you, you can fetch the PR, fix the author/commiter ammed and forcepush the branch.

You seem to trigger the https://github.com/eclipse-jdt/eclipse.jdt.ui/blob/master/.github/workflows/updateRelease.yml by creating a milestone with the eclipse-bot-user.

This triggers the create-pull-request action that will set the author in the following format:

${{ github.actor }} <${{ github.actor_id }}+${{ github.actor }}@users.noreply.github.com>

this is also what can be seen in the actual commit:

From: eclipse-releng-bot 98035380+eclipse-releng-bot@users.noreply.github.com

This author name is not accepted by the eca check. The following bots are configured for the jdt project to be whitelisted:

so in your case the author should have a name of eclipse-releng-bot and an email of releng-bot@eclipse.org

The create-pull-request action has details on how to specify the author:

https://github.com/peter-evans/create-pull-request?tab=readme-ov-file#action-inputs

added ECA in Eclipse Foundation / Help Desk team:webdev labels

assigned to @malowe

added statetodo label

unassigned @malowe

Sorry for the noise, @malowe. It seems that @netomi has already suggested a solution. Nevertheless, please feel free to contribute any further details that you believe could be helpful.

Yeah, this looks to be an issue with the committer used by the action to create the commits as Thomas said. We haven't added github-actions as a bot or allowlisted user as it's a bit too wide of a definition from what I can tell. The commits will need to be generated with the proper user info to be properly detected as a bot commit.

In the meantime, a commit amend + force push would be a quick fix to get this unblocked and passing the ECA check while the full fix is applied.

As said nothing was changed prior to last release where it worked without any special user intervention:

Prepare 4.31: https://github.com/eclipse-platform/eclipse.platform.releng.aggregator/pull/1577

Prepare 4.32: https://github.com/eclipse-platform/eclipse.platform.releng.aggregator/pull/1853

For 4.31, the user account/email is detected as eclipse-releng-bot@users.noreply.github.com, while for 4.32 it is detected as 41898282+github-actions[bot]@users.noreply.github.com. This seems to be caused by an auto-update to the create-pull-request action in the upstream eclipse-platform GH action used here on February 1st. The committer now defaults to the GH actions bot account, which tracks with the error that you are encountering.

The user that authored the commit changed:

From: eclipse-releng-bot eclipse-releng-bot@users.noreply.github.com

vs.

From: eclipse-releng-bot 98035380+eclipse-releng-bot@users.noreply.github.com

This is the official github noreply address since 2017:

https://docs.github.com/en/account-and-profile/setting-up-and-managing-your-personal-account-on-github/managing-email-preferences/setting-your-commit-email-address#about-commit-email-addresses

If you created your account on GitHub.com after July 18, 2017, your noreply email address for GitHub is an ID number and your username in the form of ID+USERNAME@users.noreply.github.com. If you created your account on GitHub.com prior to July 18, 2017, and enabled Keep my email address private prior to that date, your noreply email address from GitHub is USERNAME@users.noreply.github.com. You can get an ID-based noreply email address for GitHub by selecting (or deselecting and reselecting) Keep my email address private in your email settings.

so I think ECA should support both formats.

The difference is the use of the https://github.com/peter-evans/create-pull-request/ action.

From 5.0.2 to 6.0.1, the changelog states that the author is treated differently:

The default value for author has been changed to ${{ github.actor }} <${{ github.actor_id }}+${{ github.actor }}@users.noreply.github.com>. The change adds the ${{ github.actor_id }}+ prefix to the email address to align with GitHub's standard format for the author email address.

https://github.com/peter-evans/create-pull-request/releases/tag/v6.0.0

@netomi It think it is quite fair to change the defaults after 7 (!) years, that why I would suggest to either adjust the automatic handling of noreply github address (if there is any) or add an additional record for the releng-bot (where ever this is maintained).

I am just analyzing the root cause, its up to others to decide if the eca-check should be updated accordingly.

Yes that fine, I just wanted to note what would be the probably the desired behavior, the eclipse-bot is accepted as a "valid" user, either with new or old noreply address because we don't want to "fight" the defaults :-)

The ECA validation should support @users.noreply.github.com email address.

Let's move this issue to the ECA validation project so that we can fix that!

We already support both formats for bots since last year, both formats like 123456+username and username with either domain of @users.noreply.github.com or @noreply.github.com. The way that this works with bot accounts is if the commit email is set with one of the supported noreply domains, it extracts the username taking into account both of the valid formats. This is then checked against the username field of the bots return.

In this case, you would want a noreply that has eclipse-releng-bot or eclipse-jdt-bot as the username. With that, any repository under the eclipse.jdt project will detect that commit as coming from a bot.

Source code for relevant methods:

so then only the allow list at https://gitlab.eclipse.org/eclipsefdn/it/api/git-eca-rest-api/-/blob/main/src/main/resources/application.properties?ref_type=heads#L53

would need to be adapted to whitelist 41898282+github-actions[bot]@users.noreply.github.com ?

would need to be adapted to whitelist 41898282+github-actions[bot]@users.noreply.github.com ?

We could add it there yes! I can make a patch today and roll it out tomorrow

I just wanted to note that Tycho has a lot of PRs from "github-bot" for example here:

https://github.com/eclipse-tycho/tycho/pull/3513

that succeeds, here it seems for some reason that the github actions bot is the "committer" and the eclipse-releng the "author"

not sure who (from IP point of view) is the one who needs to be legally covered.

moved from eclipsefdn/helpdesk#4374 (moved)

assigned to @malowe

added Bug label

mentioned in commit cc131838

ECA validation error

Summary

What is the current bug behavior?

Relevant logs and/or screenshots

Priority

Severity

Impact

Designs

Child items ...

Activity