Added unit tests, secret config to be used w/k8s, licenses

Signed-off-by: Martin Lowe <martin.lowe@eclipse-foundation.org>

.gitignore

@@ -32,4 +32,9 @@ target/
 pom.xml.tag
 pom.xml.releaseBackup
 pom.xml.versionsBackup
-release.properties
\ No newline at end of file
+release.properties
+
+# Secret store
+secret/
+secrets/
+secret.properties
\ No newline at end of file

LICENSE

+Eclipse Public License - v 2.0
+
+    THE ACCOMPANYING PROGRAM IS PROVIDED UNDER THE TERMS OF THIS ECLIPSE
+    PUBLIC LICENSE ("AGREEMENT"). ANY USE, REPRODUCTION OR DISTRIBUTION
+    OF THE PROGRAM CONSTITUTES RECIPIENT'S ACCEPTANCE OF THIS AGREEMENT.
+
+1. DEFINITIONS
+
+"Contribution" means:
+
+  a) in the case of the initial Contributor, the initial content
+     Distributed under this Agreement, and
+
+  b) in the case of each subsequent Contributor:
+     i) changes to the Program, and
+     ii) additions to the Program;
+  where such changes and/or additions to the Program originate from
+  and are Distributed by that particular Contributor. A Contribution
+  "originates" from a Contributor if it was added to the Program by
+  such Contributor itself or anyone acting on such Contributor's behalf.
+  Contributions do not include changes or additions to the Program that
+  are not Modified Works.
+
+"Contributor" means any person or entity that Distributes the Program.
+
+"Licensed Patents" mean patent claims licensable by a Contributor which
+are necessarily infringed by the use or sale of its Contribution alone
+or when combined with the Program.
+
+"Program" means the Contributions Distributed in accordance with this
+Agreement.
+
+"Recipient" means anyone who receives the Program under this Agreement
+or any Secondary License (as applicable), including Contributors.
+
+"Derivative Works" shall mean any work, whether in Source Code or other
+form, that is based on (or derived from) the Program and for which the
+editorial revisions, annotations, elaborations, or other modifications
+represent, as a whole, an original work of authorship.
+
+"Modified Works" shall mean any work in Source Code or other form that
+results from an addition to, deletion from, or modification of the
+contents of the Program, including, for purposes of clarity any new file
+in Source Code form that contains any contents of the Program. Modified
+Works shall not include works that contain only declarations,
+interfaces, types, classes, structures, or files of the Program solely
+in each case in order to link to, bind by name, or subclass the Program
+or Modified Works thereof.
+
+"Distribute" means the acts of a) distributing or b) making available
+in any manner that enables the transfer of a copy.
+
+"Source Code" means the form of a Program preferred for making
+modifications, including but not limited to software source code,
+documentation source, and configuration files.
+
+"Secondary License" means either the GNU General Public License,
+Version 2.0, or any later versions of that license, including any
+exceptions or additional permissions as identified by the initial
+Contributor.
+
+2. GRANT OF RIGHTS
+
+  a) Subject to the terms of this Agreement, each Contributor hereby
+  grants Recipient a non-exclusive, worldwide, royalty-free copyright
+  license to reproduce, prepare Derivative Works of, publicly display,
+  publicly perform, Distribute and sublicense the Contribution of such
+  Contributor, if any, and such Derivative Works.
+
+  b) Subject to the terms of this Agreement, each Contributor hereby
+  grants Recipient a non-exclusive, worldwide, royalty-free patent
+  license under Licensed Patents to make, use, sell, offer to sell,
+  import and otherwise transfer the Contribution of such Contributor,
+  if any, in Source Code or other form. This patent license shall
+  apply to the combination of the Contribution and the Program if, at
+  the time the Contribution is added by the Contributor, such addition
+  of the Contribution causes such combination to be covered by the
+  Licensed Patents. The patent license shall not apply to any other
+  combinations which include the Contribution. No hardware per se is
+  licensed hereunder.
+
+  c) Recipient understands that although each Contributor grants the
+  licenses to its Contributions set forth herein, no assurances are
+  provided by any Contributor that the Program does not infringe the
+  patent or other intellectual property rights of any other entity.
+  Each Contributor disclaims any liability to Recipient for claims
+  brought by any other entity based on infringement of intellectual
+  property rights or otherwise. As a condition to exercising the
+  rights and licenses granted hereunder, each Recipient hereby
+  assumes sole responsibility to secure any other intellectual
+  property rights needed, if any. For example, if a third party
+  patent license is required to allow Recipient to Distribute the
+  Program, it is Recipient's responsibility to acquire that license
+  before distributing the Program.
+
+  d) Each Contributor represents that to its knowledge it has
+  sufficient copyright rights in its Contribution, if any, to grant
+  the copyright license set forth in this Agreement.
+
+  e) Notwithstanding the terms of any Secondary License, no
+  Contributor makes additional grants to any Recipient (other than
+  those set forth in this Agreement) as a result of such Recipient's
+  receipt of the Program under the terms of a Secondary License
+  (if permitted under the terms of Section 3).
+
+3. REQUIREMENTS
+
+3.1 If a Contributor Distributes the Program in any form, then:
+
+  a) the Program must also be made available as Source Code, in
+  accordance with section 3.2, and the Contributor must accompany
+  the Program with a statement that the Source Code for the Program
+  is available under this Agreement, and informs Recipients how to
+  obtain it in a reasonable manner on or through a medium customarily
+  used for software exchange; and
+
+  b) the Contributor may Distribute the Program under a license
+  different than this Agreement, provided that such license:
+     i) effectively disclaims on behalf of all other Contributors all
+     warranties and conditions, express and implied, including
+     warranties or conditions of title and non-infringement, and
+     implied warranties or conditions of merchantability and fitness
+     for a particular purpose;
+
+     ii) effectively excludes on behalf of all other Contributors all
+     liability for damages, including direct, indirect, special,
+     incidental and consequential damages, such as lost profits;
+
+     iii) does not attempt to limit or alter the recipients' rights
+     in the Source Code under section 3.2; and
+
+     iv) requires any subsequent distribution of the Program by any
+     party to be under a license that satisfies the requirements
+     of this section 3.
+
+3.2 When the Program is Distributed as Source Code:
+
+  a) it must be made available under this Agreement, or if the
+  Program (i) is combined with other material in a separate file or
+  files made available under a Secondary License, and (ii) the initial
+  Contributor attached to the Source Code the notice described in
+  Exhibit A of this Agreement, then the Program may be made available
+  under the terms of such Secondary Licenses, and
+
+  b) a copy of this Agreement must be included with each copy of
+  the Program.
+
+3.3 Contributors may not remove or alter any copyright, patent,
+trademark, attribution notices, disclaimers of warranty, or limitations
+of liability ("notices") contained within the Program from any copy of
+the Program which they Distribute, provided that Contributors may add
+their own appropriate notices.
+
+4. COMMERCIAL DISTRIBUTION
+
+Commercial distributors of software may accept certain responsibilities
+with respect to end users, business partners and the like. While this
+license is intended to facilitate the commercial use of the Program,
+the Contributor who includes the Program in a commercial product
+offering should do so in a manner which does not create potential
+liability for other Contributors. Therefore, if a Contributor includes
+the Program in a commercial product offering, such Contributor
+("Commercial Contributor") hereby agrees to defend and indemnify every
+other Contributor ("Indemnified Contributor") against any losses,
+damages and costs (collectively "Losses") arising from claims, lawsuits
+and other legal actions brought by a third party against the Indemnified
+Contributor to the extent caused by the acts or omissions of such
+Commercial Contributor in connection with its distribution of the Program
+in a commercial product offering. The obligations in this section do not
+apply to any claims or Losses relating to any actual or alleged
+intellectual property infringement. In order to qualify, an Indemnified
+Contributor must: a) promptly notify the Commercial Contributor in
+writing of such claim, and b) allow the Commercial Contributor to control,
+and cooperate with the Commercial Contributor in, the defense and any
+related settlement negotiations. The Indemnified Contributor may
+participate in any such claim at its own expense.
+
+For example, a Contributor might include the Program in a commercial
+product offering, Product X. That Contributor is then a Commercial
+Contributor. If that Commercial Contributor then makes performance
+claims, or offers warranties related to Product X, those performance
+claims and warranties are such Commercial Contributor's responsibility
+alone. Under this section, the Commercial Contributor would have to
+defend claims against the other Contributors related to those performance
+claims and warranties, and if a court requires any other Contributor to
+pay any damages as a result, the Commercial Contributor must pay
+those damages.
+
+5. NO WARRANTY
+
+EXCEPT AS EXPRESSLY SET FORTH IN THIS AGREEMENT, AND TO THE EXTENT
+PERMITTED BY APPLICABLE LAW, THE PROGRAM IS PROVIDED ON AN "AS IS"
+BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, EITHER EXPRESS OR
+IMPLIED INCLUDING, WITHOUT LIMITATION, ANY WARRANTIES OR CONDITIONS OF
+TITLE, NON-INFRINGEMENT, MERCHANTABILITY OR FITNESS FOR A PARTICULAR
+PURPOSE. Each Recipient is solely responsible for determining the
+appropriateness of using and distributing the Program and assumes all
+risks associated with its exercise of rights under this Agreement,
+including but not limited to the risks and costs of program errors,
+compliance with applicable laws, damage to or loss of data, programs
+or equipment, and unavailability or interruption of operations.
+
+6. DISCLAIMER OF LIABILITY
+
+EXCEPT AS EXPRESSLY SET FORTH IN THIS AGREEMENT, AND TO THE EXTENT
+PERMITTED BY APPLICABLE LAW, NEITHER RECIPIENT NOR ANY CONTRIBUTORS
+SHALL HAVE ANY LIABILITY FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL,
+EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING WITHOUT LIMITATION LOST
+PROFITS), HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
+CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
+ARISING IN ANY WAY OUT OF THE USE OR DISTRIBUTION OF THE PROGRAM OR THE
+EXERCISE OF ANY RIGHTS GRANTED HEREUNDER, EVEN IF ADVISED OF THE
+POSSIBILITY OF SUCH DAMAGES.
+
+7. GENERAL
+
+If any provision of this Agreement is invalid or unenforceable under
+applicable law, it shall not affect the validity or enforceability of
+the remainder of the terms of this Agreement, and without further
+action by the parties hereto, such provision shall be reformed to the
+minimum extent necessary to make such provision valid and enforceable.
+
+If Recipient institutes patent litigation against any entity
+(including a cross-claim or counterclaim in a lawsuit) alleging that the
+Program itself (excluding combinations of the Program with other software
+or hardware) infringes such Recipient's patent(s), then such Recipient's
+rights granted under Section 2(b) shall terminate as of the date such
+litigation is filed.
+
+All Recipient's rights under this Agreement shall terminate if it
+fails to comply with any of the material terms or conditions of this
+Agreement and does not cure such failure in a reasonable period of
+time after becoming aware of such noncompliance. If all Recipient's
+rights under this Agreement terminate, Recipient agrees to cease use
+and distribution of the Program as soon as reasonably practicable.
+However, Recipient's obligations under this Agreement and any licenses
+granted by Recipient relating to the Program shall continue and survive.
+
+Everyone is permitted to copy and distribute copies of this Agreement,
+but in order to avoid inconsistency the Agreement is copyrighted and
+may only be modified in the following manner. The Agreement Steward
+reserves the right to publish new versions (including revisions) of
+this Agreement from time to time. No one other than the Agreement
+Steward has the right to modify this Agreement. The Eclipse Foundation
+is the initial Agreement Steward. The Eclipse Foundation may assign the
+responsibility to serve as the Agreement Steward to a suitable separate
+entity. Each new version of the Agreement will be given a distinguishing
+version number. The Program (including Contributions) may always be
+Distributed subject to the version of the Agreement under which it was
+received. In addition, after a new version of the Agreement is published,
+Contributor may elect to Distribute the Program (including its
+Contributions) under the new version.
+
+Except as expressly stated in Sections 2(a) and 2(b) above, Recipient
+receives no rights or licenses to the intellectual property of any
+Contributor under this Agreement, whether expressly, by implication,
+estoppel or otherwise. All rights in the Program not expressly granted
+under this Agreement are reserved. Nothing in this Agreement is intended
+to be enforceable by any entity that is not a Contributor or Recipient.
+No third-party beneficiary rights are created under this Agreement.
+
+Exhibit A - Form of Secondary Licenses Notice
+
+"This Source Code may also be made available under the following 
+Secondary Licenses when the conditions for such availability set forth 
+in the Eclipse Public License, v. 2.0 are satisfied: {name license(s),
+version(s), and exceptions or additional permissions here}."
+
+  Simply including a copy of this Agreement, including this Exhibit A
+  is not sufficient to license the Source Code under Secondary Licenses.
+
+  If it is not possible or desirable to put the notice in a particular
+  file, then You may include the notice in a location (such as a LICENSE
+  file in a relevant directory) where a recipient would be likely to
+  look for such a notice.
+
+  You may add additional accurate notices of copyright ownership.

README.md

@@ -14,17 +14,17 @@ You can run your application in dev mode that enables live coding using:
 ## Packaging and running the application
 
 The application is packageable using `./mvnw package`.
-It produces the executable `gitlab.cla-0.0.1-runner.jar` file in `/target` directory.
+It produces the executable `git-eca-rest-api-0.0.1-runner.jar` file in `/target` directory.
 Be aware that it’s not an _über-jar_ as the dependencies are copied into the `target/lib` directory.
 
-The application is now runnable using `java -jar target/gitlab.cla-0.0.1-runner.jar`.
+The application is now runnable using `java -jar target/git-eca-rest-api-0.0.1-runner.jar`.
 
 ## Enabling commit hook in GitLab
 
 To enable the Git hook that makes use of this service, a running GitLab instance will be needed with shell access. This instruction set assumes that the running GitLab instance runs using the Omnibus set up rather than the source. For the differences in process, please see the [GitLab custom hook administration instructions](https://docs.gitlab.com/ee/administration/custom_hooks.html). Once obtained, the following steps can be used to start or update the hook.
 
 1. Access the GitLab server shell, and create a folder at `/opt/gitlab/embedded/service/gitlab-shell/hooks/pre-receive.d/` if it doesn't already exist. This folder will contain all of the servers global Git hooks for pre-receive events. These hooks trigger when a user attempts to push information to the server.  
-1. In the host machine, copy the CLA script to the newly created folder. If using a docker container, this can be done with a call similar to the following:  
-`docker cp src/main/shell/gitlab_cla.sh gitlab.eca_web_1:/opt/gitlab/embedded/service/gitlab-shell/hooks/pre-receive.d/`
+1. In the host machine, copy the ECA script to the newly created folder. If using a docker container, this can be done with a call similar to the following:  
+`docker cp src/main/rb/eca.rb gitlab.eca_web_1:/opt/gitlab/embedded/service/gitlab-shell/hooks/pre-receive.d/`
 
 1. In the GitLab shell once again, ensure that the newly copied script matches the folders ownership, and that the file permissions are `755`. This allows the server to properly run the hook when needed.
\ No newline at end of file

config/sample.secret.properties

+## Required for authenticated requests to profile API
+oauth2.client-id=sample
+oauth2.client-secret=sample
\ No newline at end of file

pom.xml

@@ -19,6 +19,12 @@
 		<quarkus.platform.group-id>io.quarkus</quarkus.platform.group-id>
 		<quarkus.platform.version>1.1.1.Final</quarkus.platform.version>
 		<surefire-plugin.version>2.22.1</surefire-plugin.version>
+		<sonar.sources>src/main</sonar.sources>
+		<sonar.tests>src/test</sonar.tests>
+		<sonar.java.coveragePlugin>jacoco</sonar.java.coveragePlugin>
+		<sonar.dynamicAnalysis>reuseReports</sonar.dynamicAnalysis>
+		<sonar.jacoco.reportPaths>${project.build.directory}/jacoco-report</sonar.jacoco.reportPaths>
+		<sonar.junit.reportPath>${project.build.directory}/surefire-reports</sonar.junit.reportPath>
 	</properties>
 	<dependencyManagement>
 		<dependencies>
@@ -59,11 +65,6 @@
 			<artifactId>scribejava-apis</artifactId>
 			<version>6.4.1</version>
 		</dependency>
-		<dependency>
-			<groupId>org.gitlab4j</groupId>
-			<artifactId>gitlab4j-api</artifactId>
-			<version>4.14.11</version>
-		</dependency>
 		
 		<!-- Caching -->
 		<dependency>
@@ -133,5 +134,50 @@
 				<quarkus.package.type>native</quarkus.package.type>
 			</properties>
 		</profile>
+		<profile>
+			<id>sonar-dev</id>
+			<build>
+				<plugins>
+					<plugin>
+						<artifactId>maven-surefire-plugin</artifactId>
+						<version>${surefire-plugin.version}</version>
+					</plugin>
+					<plugin>
+						<groupId>org.jacoco</groupId>
+						<artifactId>jacoco-maven-plugin</artifactId>
+						<version>0.8.4</version>
+						<configuration>
+							<destFile>${sonar.jacoco.reportPaths}</destFile>
+							<append>true</append>
+						</configuration>
+						<executions>
+							<execution>
+								<goals>
+									<goal>prepare-agent</goal>
+								</goals>
+							</execution>
+							<execution>
+								<id>report</id>
+								<phase>test</phase>
+								<goals>
+									<goal>report</goal>
+								</goals>
+								<configuration>
+									<outputDirectory>${sonar.jacoco.reportPaths}</outputDirectory>
+								</configuration>
+							</execution>
+						</executions>
+					</plugin>
+					<plugin>
+						<groupId>org.sonarsource.scanner.maven</groupId>
+						<artifactId>sonar-maven-plugin</artifactId>
+						<version>3.6.0.1398</version>
+					</plugin>
+				</plugins>
+			</build>
+			<properties>
+				<sonar.host.url>https://sonarqube.dev.docker</sonar.host.url>
+			</properties>
+		</profile>
 	</profiles>
 </project>

src/main/docker/Dockerfile.jvm

@@ -7,11 +7,11 @@
 #
 # Then, build the image with:
 #
-# docker build -f src/main/docker/Dockerfile.jvm -t quarkus/gitlab.cla-jvm .
+# docker build -f src/main/docker/Dockerfile.jvm -t eclipsefdn/git-eca-rest-api-jvm .
 #
 # Then run the container using:
 #
-# docker run -i --rm -p 8080:8080 quarkus/gitlab.cla-jvm
+# docker run -i --rm -p 8080:8080 eclipsefdn/git-eca-rest-api-jvm
 #
 ###
 FROM fabric8/java-alpine-openjdk8-jre:1.6.5

src/main/java/org/eclipsefoundation/git/eca/api/AccountsAPI.java

+/*******************************************************************************
+ * Copyright (C) 2020 Eclipse Foundation
+ * 
+ * This program and the accompanying materials are made
+ * available under the terms of the Eclipse Public License 2.0
+ * which is available at https://www.eclipse.org/legal/epl-2.0/
+ * 
+ * SPDX-License-Identifier: EPL-2.0
+ ******************************************************************************/
 package org.eclipsefoundation.git.eca.api;
 
 import java.util.List;

src/main/java/org/eclipsefoundation/git/eca/api/BotsAPI.java

+/*******************************************************************************
+ * Copyright (C) 2020 Eclipse Foundation
+ * 
+ * This program and the accompanying materials are made
+ * available under the terms of the Eclipse Public License 2.0
+ * which is available at https://www.eclipse.org/legal/epl-2.0/
+ * 
+ * SPDX-License-Identifier: EPL-2.0
+ ******************************************************************************/
 package org.eclipsefoundation.git.eca.api;
 
 import java.util.List;

src/main/java/org/eclipsefoundation/git/eca/api/ProjectsAPI.java

+/*******************************************************************************
+ * Copyright (C) 2020 Eclipse Foundation
+ * 
+ * This program and the accompanying materials are made
+ * available under the terms of the Eclipse Public License 2.0
+ * which is available at https://www.eclipse.org/legal/epl-2.0/
+ * 
+ * SPDX-License-Identifier: EPL-2.0
+ ******************************************************************************/
 package org.eclipsefoundation.git.eca.api;
 
 import java.util.List;
@@ -5,7 +14,6 @@ import java.util.List;
 import javax.ws.rs.GET;
 import javax.ws.rs.Path;
 import javax.ws.rs.Produces;
-import javax.ws.rs.QueryParam;
 
 import org.eclipse.microprofile.rest.client.inject.RegisterRestClient;
 import org.eclipsefoundation.git.eca.model.Project;
@@ -29,5 +37,5 @@ public interface ProjectsAPI {
 	 */
 	@GET
 	@Produces("application/json")
-	List<Project> getProject(@QueryParam("repoUrl") String repoUrl);
+	List<Project> getProject();
 }

src/main/java/org/eclipsefoundation/git/eca/config/CustomJacksonConfig.java

+/*******************************************************************************
+ * Copyright (C) 2020 Eclipse Foundation
+ * 
+ * This program and the accompanying materials are made
+ * available under the terms of the Eclipse Public License 2.0
+ * which is available at https://www.eclipse.org/legal/epl-2.0/
+ * 
+ * SPDX-License-Identifier: EPL-2.0
+ ******************************************************************************/
 package org.eclipsefoundation.git.eca.config;
 
 import javax.inject.Singleton;

src/main/java/org/eclipsefoundation/git/eca/config/SecretConfigSource.java

+/*******************************************************************************
+ * Copyright (C) 2020 Eclipse Foundation
+ * 
+ * This program and the accompanying materials are made
+ * available under the terms of the Eclipse Public License 2.0
+ * which is available at https://www.eclipse.org/legal/epl-2.0/
+ * 
+ * SPDX-License-Identifier: EPL-2.0
+ ******************************************************************************/
+package org.eclipsefoundation.git.eca.config;
+
+import java.io.BufferedReader;
+import java.io.File;
+import java.io.FileReader;
+import java.io.IOException;
+import java.util.HashMap;
+import java.util.Map;
+import java.util.Properties;
+import java.util.ServiceLoader;
+
+import org.eclipse.microprofile.config.spi.ConfigSource;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+/**
+ * Reads in a set of secret configuration values from the secret.properties file
+ * in the resources folder. These values are only secret in that they are set to
+ * be ignored by Git and should be set on a per-server basis.
+ * 
+ * ConfigSource implementation was used to enable the usage of the
+ * {@link ServiceLoader} to load the configurations.
+ * 
+ * @author Martin Lowe
+ */
+public class SecretConfigSource implements ConfigSource {
+	private static final Logger LOGGER = LoggerFactory.getLogger(SecretConfigSource.class);
+	
+	private static final String DEFAULT_SECRET_LOCATION = "/run/secrets/secret.properties";
+	
+	private Map<String, String> secrets;
+
+	@Override
+	public Map<String, String> getProperties() {
+		if (secrets == null) {
+			this.secrets = new HashMap<>();
+			String secretPath = System.getProperty("config.secret.path");
+			// Fallback to checking env if not set in JVM
+			if (secretPath == null || "".equals(secretPath.trim())) {
+				secretPath = System.getenv("config.secret.path");
+			}
+			if (secretPath == null || "".equals(secretPath.trim())) {
+				LOGGER.error("Configuration 'config.secret.path' not set, using default value of " + DEFAULT_SECRET_LOCATION);
+				secretPath = DEFAULT_SECRET_LOCATION;
+			}
+			// load the secrets file in
+			File f = new File(secretPath);
+			if (!f.exists() || !f.canRead()) {
+				LOGGER.error("File at path {} either does not exist or cannot be read", secretPath);
+				return this.secrets;
+			}
+
+			// read each of the lines of secret config that should be added
+			try (BufferedReader br = new BufferedReader(new FileReader(f))) {
+				Properties p = new Properties();
+				p.load(br);
+				secrets.putAll((Map) p);
+
+			} catch (IOException e) {
+				LOGGER.error("Error while reading in secrets configuration file.", e);
+			}
+			LOGGER.debug("Found secret keys: {}", secrets.keySet());
+
+			// add priority ordinal to map if missing. 260 ordinal sets the priority between
+			// container and environment variable priority.
+			secrets.computeIfAbsent(ConfigSource.CONFIG_ORDINAL, key -> "260");
+		}
+		return secrets;
+	}
+
+	@Override
+	public String getValue(String propertyName) {
+		return getProperties().get(propertyName);
+	}
+
+	@Override
+	public String getName() {
+		return "secret";
+	}
+}

src/main/java/org/eclipsefoundation/git/eca/helper/CommitHelper.java

+/*******************************************************************************
+ * Copyright (C) 2020 Eclipse Foundation
+ *
+ * This program and the accompanying materials are made
+ * available under the terms of the Eclipse Public License 2.0
+ * which is available at https://www.eclipse.org/legal/epl-2.0/
+ *
+ * SPDX-License-Identifier: EPL-2.0
+ ******************************************************************************/
 package org.eclipsefoundation.git.eca.helper;
 
 import java.util.regex.Matcher;
@@ -7,16 +16,16 @@ import org.eclipsefoundation.git.eca.model.Commit;
 
 /**
  * Contains helpers for processing commits.
- * 
+ *
  * @author Martin Lowe
  *
  */
 public class CommitHelper {
-	private static final Pattern SIGNED_OFF_BY_FOOTER = Pattern.compile("Signed-off-by:(.*)<(.*@.*)>$");
+	private static final Pattern SIGNED_OFF_BY_FOOTER = Pattern.compile("Signed-off-by:(.*)<(.*@.*)>\\s*$");
 
 	/**
 	 * Validate the commits fields.
-	 * 
+	 *
 	 * @param c commit to validate
 	 * @return true if valid, otherwise false
 	 */
@@ -27,7 +36,7 @@ public class CommitHelper {
 
 		boolean valid = true;
 		// check current commit data
-		if (c.getHash() == null || c.getParents() == null) {
+		if (c.getHash() == null) {
 			valid = false;
 		}
 		// check author
@@ -45,7 +54,7 @@ public class CommitHelper {
 	/**
 	 * Retrieves the email address associated with a commit message. This is done by
 	 * processing the body and parsing out the given footer knowing its format.
-	 * 
+	 *
 	 * @param c the commit to retrieve the signed off by footer for
 	 * @return the email address in the Signed-off-by footer, or null if none could
 	 *         be found.

src/main/java/org/eclipsefoundation/git/eca/model/BotUser.java

+/*******************************************************************************
+ * Copyright (C) 2020 Eclipse Foundation
+ * 
+ * This program and the accompanying materials are made
+ * available under the terms of the Eclipse Public License 2.0
+ * which is available at https://www.eclipse.org/legal/epl-2.0/
+ * 
+ * SPDX-License-Identifier: EPL-2.0
+ ******************************************************************************/
 package org.eclipsefoundation.git.eca.model;
 
 /**

src/main/java/org/eclipsefoundation/git/eca/model/Commit.java

+/*******************************************************************************
+ * Copyright (C) 2020 Eclipse Foundation
+ * 
+ * This program and the accompanying materials are made
+ * available under the terms of the Eclipse Public License 2.0
+ * which is available at https://www.eclipse.org/legal/epl-2.0/
+ * 
+ * SPDX-License-Identifier: EPL-2.0
+ ******************************************************************************/
 package org.eclipsefoundation.git.eca.model;
 
+import java.util.ArrayList;
+import java.util.List;
+
 /**
  * Represents a Git commit with basic data and metadata about the revision.
  * 
@@ -10,9 +22,9 @@ public class Commit {
 	private String hash;
 	private String subject;
 	private String body;
-	private String parents;
+	private List<String> parents;
 	private GitUser author;
-	private GitUser commiter;
+	private GitUser committer;
 	private boolean head;
 
 	/**
@@ -60,15 +72,15 @@ public class Commit {
 	/**
 	 * @return the parents
 	 */
-	public String getParents() {
-		return parents;
+	public List<String> getParents() {
+		return new ArrayList<>(parents);
 	}
 
 	/**
 	 * @param parents the parents to set
 	 */
-	public void setParents(String parents) {
-		this.parents = parents;
+	public void setParents(List<String> parents) {
+		this.parents = new ArrayList<>(parents);
 	}
 
 	/**
@@ -89,14 +101,14 @@ public class Commit {
 	 * @return the commiter
 	 */
 	public GitUser getCommitter() {
-		return commiter;
+		return committer;
 	}
 
 	/**
-	 * @param commiter the commiter to set
+	 * @param committer the committer to set
 	 */
-	public void setCommiter(GitUser commiter) {
-		this.commiter = commiter;
+	public void setCommitter(GitUser committer) {
+		this.committer = committer;
 	}
 
 	/**
@@ -112,23 +124,4 @@ public class Commit {
 	public void setHead(boolean head) {
 		this.head = head;
 	}
-
-	@Override
-	public String toString() {
-		StringBuilder builder = new StringBuilder();
-		builder.append("Commit [hash=");
-		builder.append(hash);
-		builder.append(", subject=");
-		builder.append(subject);
-		builder.append(", body=");
-		builder.append(body);
-		builder.append(", parents=");
-		builder.append(parents);
-		builder.append(", author=");
-		builder.append(author);
-		builder.append(", commiter=");
-		builder.append(commiter);
-		builder.append("]");
-		return builder.toString();
-	}
 }

src/main/java/org/eclipsefoundation/git/eca/model/CommitStatus.java

+/*******************************************************************************
+ * Copyright (C) 2020 Eclipse Foundation
+ * 
+ * This program and the accompanying materials are made
+ * available under the terms of the Eclipse Public License 2.0
+ * which is available at https://www.eclipse.org/legal/epl-2.0/
+ * 
+ * SPDX-License-Identifier: EPL-2.0
+ ******************************************************************************/
 package org.eclipsefoundation.git.eca.model;
 
 import java.util.ArrayList;
@@ -108,4 +117,4 @@ public class CommitStatus {
 			this.message = message;
 		}
 	}
-}
\ No newline at end of file
+}

src/main/java/org/eclipsefoundation/git/eca/model/EclipseUser.java

+/*******************************************************************************
+ * Copyright (C) 2020 Eclipse Foundation
+ * 
+ * This program and the accompanying materials are made
+ * available under the terms of the Eclipse Public License 2.0
+ * which is available at https://www.eclipse.org/legal/epl-2.0/
+ * 
+ * SPDX-License-Identifier: EPL-2.0
+ ******************************************************************************/
 package org.eclipsefoundation.git.eca.model;
 
-import java.util.Objects;
-
 import com.fasterxml.jackson.databind.PropertyNamingStrategy;
 import com.fasterxml.jackson.databind.annotation.JsonNaming;
 
@@ -88,49 +95,23 @@ public class EclipseUser {
 		this.isCommitter = isCommitter;
 	}
 
-	@Override
-	public String toString() {
-		StringBuilder builder = new StringBuilder();
-		builder.append("EclipseAccount [id=");
-		builder.append(uid);
-		builder.append(", name=");
-		builder.append(name);
-		builder.append(", mail=");
-		builder.append(mail);
-		builder.append(", eca=");
-		builder.append(eca);
-		builder.append(", isCommitter=");
-		builder.append(isCommitter);
-		builder.append("]");
-		return builder.toString();
-	}
-
-	@Override
-	public int hashCode() {
-		return Objects.hash(eca, isCommitter, mail, name, uid);
-	}
-
-	@Override
-	public boolean equals(Object obj) {
-		if (this == obj)
-			return true;
-		if (obj == null)
-			return false;
-		if (getClass() != obj.getClass())
-			return false;
-		EclipseUser other = (EclipseUser) obj;
-		return Objects.equals(eca, other.eca) && isCommitter == other.isCommitter && Objects.equals(mail, other.mail)
-				&& Objects.equals(name, other.name) && uid == other.uid;
-	}
-
 	/**
 	 * ECA for Eclipse accounts, representing whether users have signed the Eclipse
 	 * Committer Agreement to enable contribution.
 	 */
 	@JsonNaming(PropertyNamingStrategy.SnakeCaseStrategy.class)
 	public static class ECA {
-		private boolean signed = false;
-		private boolean canContributeSpecProject = false;
+		private boolean signed;
+		private boolean canContributeSpecProject;
+		
+		public ECA() {
+			this(false, false);
+		}
+		
+		public ECA(boolean signed, boolean canContributeSpecProject) {
+			this.signed = signed;
+			this.canContributeSpecProject = canContributeSpecProject;
+		}
 
 		/**
 		 * @return the signed
@@ -159,34 +140,5 @@ public class EclipseUser {
 		public void setCanContributeSpecProject(boolean canContributeSpecProject) {
 			this.canContributeSpecProject = canContributeSpecProject;
 		}
-
-		@Override
-		public int hashCode() {
-			return Objects.hash(signed, canContributeSpecProject);
-		}
-
-		@Override
-		public boolean equals(Object obj) {
-			if (this == obj)
-				return true;
-			if (obj == null)
-				return false;
-			if (getClass() != obj.getClass())
-				return false;
-			ECA other = (ECA) obj;
-			return signed == other.signed && canContributeSpecProject == other.canContributeSpecProject;
-		}
-
-		@Override
-		public String toString() {
-			StringBuilder builder = new StringBuilder();
-			builder.append("ECA [signed=");
-			builder.append(signed);
-			builder.append(", canContributeSpecProject=");
-			builder.append(canContributeSpecProject);
-			builder.append("]");
-			return builder.toString();
-
-		}
 	}
 }

src/main/java/org/eclipsefoundation/git/eca/model/GitUser.java

+/*******************************************************************************
+ * Copyright (C) 2020 Eclipse Foundation
+ * 
+ * This program and the accompanying materials are made
+ * available under the terms of the Eclipse Public License 2.0
+ * which is available at https://www.eclipse.org/legal/epl-2.0/
+ * 
+ * SPDX-License-Identifier: EPL-2.0
+ ******************************************************************************/
 package org.eclipsefoundation.git.eca.model;
 
 /**
@@ -37,16 +46,4 @@ public class GitUser {
 	public void setMail(String mail) {
 		this.mail = mail;
 	}
-
-	@Override
-	public String toString() {
-		StringBuilder builder = new StringBuilder();
-		builder.append("User [name=");
-		builder.append(name);
-		builder.append(", mail=");
-		builder.append(mail);
-		builder.append("]");
-		return builder.toString();
-	}
-
 }

src/main/java/org/eclipsefoundation/git/eca/model/Project.java

+/*******************************************************************************
+ * Copyright (C) 2020 Eclipse Foundation
+ * 
+ * This program and the accompanying materials are made
+ * available under the terms of the Eclipse Public License 2.0
+ * which is available at https://www.eclipse.org/legal/epl-2.0/
+ * 
+ * SPDX-License-Identifier: EPL-2.0
+ ******************************************************************************/
 package org.eclipsefoundation.git.eca.model;
 
+import java.util.ArrayList;
 import java.util.List;
 import java.util.Map;
 
@@ -21,6 +31,11 @@ public class Project {
 	private List<User> committers;
 	private List<Repo> repos;
 	private String specWorkingGroup;
+	
+	public Project() {
+		this.committers = new ArrayList<>();
+		this.repos = new ArrayList<>();
+	}
 
 	/**
 	 * @return the projectId

src/main/java/org/eclipsefoundation/git/eca/model/ValidationRequest.java

+/*******************************************************************************
+ * Copyright (C) 2020 Eclipse Foundation
+ * 
+ * This program and the accompanying materials are made
+ * available under the terms of the Eclipse Public License 2.0
+ * which is available at https://www.eclipse.org/legal/epl-2.0/
+ * 
+ * SPDX-License-Identifier: EPL-2.0
+ ******************************************************************************/
 package org.eclipsefoundation.git.eca.model;
 
 import java.util.ArrayList;

src/main/java/org/eclipsefoundation/git/eca/model/ValidationResponse.java

+/*******************************************************************************
+ * Copyright (C) 2020 Eclipse Foundation
+ * 
+ * This program and the accompanying materials are made
+ * available under the terms of the Eclipse Public License 2.0
+ * which is available at https://www.eclipse.org/legal/epl-2.0/
+ * 
+ * SPDX-License-Identifier: EPL-2.0
+ ******************************************************************************/
 package org.eclipsefoundation.git.eca.model;
 
 import java.util.Date;
@@ -17,7 +26,6 @@ import org.eclipsefoundation.git.eca.namespace.APIStatusCode;
  */
 public class ValidationResponse {
 	private boolean passed;
-	private APIStatusCode status;
 	private int errorCount;
 	private Date time;
 	private Map<String, CommitStatus> commits;
@@ -97,15 +105,6 @@ public class ValidationResponse {
 	public void addError(String hash, String error, APIStatusCode code) {
 		commits.computeIfAbsent(getHashKey(hash), k -> new CommitStatus()).addError(error, code);
 	}
-	
-	public void updateStatus(APIStatusCode code) {
-		if (this.status == null) {
-			this.status = code;
-			//TODO this is _REALLY_ sloppy logic. Ask CG when have time
-		} else if (Math.abs(this.status.getValue()) < Math.abs(code.getValue())) {
-			this.status = code;
-		}
-	}
 
 	private String getHashKey(String hash) {
 		return hash == null ? "_nil" : hash;