Skip to content
Snippets Groups Projects
Commit 2819bae5 authored by Martin Lowe's avatar Martin Lowe :flag_ca:
Browse files

Fix a field that is nullable in some cases causing processing issues

parent f8e14e53
No related branches found
No related tags found
1 merge request!199Add parallel processing to the commit validation call
Pipeline #54069 passed
......@@ -106,6 +106,7 @@ public abstract class GithubCommit {
@AutoValue
@JsonDeserialize(builder = AutoValue_GithubCommit_GithubCommitUser.Builder.class)
public abstract static class GithubCommitUser {
@Nullable
public abstract String getLogin();
public static Builder builder() {
......@@ -115,7 +116,7 @@ public abstract class GithubCommit {
@AutoValue.Builder
@JsonPOJOBuilder(withPrefix = "set")
public abstract static class Builder {
public abstract Builder setLogin(String login);
public abstract Builder setLogin(@Nullable String login);
public abstract GithubCommitUser build();
}
......
......@@ -121,10 +121,10 @@ public class DefaultValidationService implements ValidationService {
/**
* Using serial/blocking processing, process the validation request.
*
* @param req
* @param filteredProjects
* @param statuses
* @return
* @param req the request to validate
* @param filteredProjects tracked projects for the current request
* @param statuses list containing historic status history for the given request
* @return validated response parts for the request to be recombined, persisted, and returned.
*/
private List<ValidationResponsePart> doSerialProcessing(ValidationRequest req, List<Project> filteredProjects,
List<CommitValidationStatus> statuses) {
......@@ -138,10 +138,10 @@ public class DefaultValidationService implements ValidationService {
/**
* Using parallel processing, process the validation request.
*
* @param req
* @param filteredProjects
* @param statuses
* @return
* @param req the request to validate
* @param filteredProjects tracked projects for the current request
* @param statuses list containing historic status history for the given request
* @return validated response parts for the request to be recombined, persisted, and returned.
*/
private List<ValidationResponsePart> doParallelProcessing(ValidationRequest req, List<Project> filteredProjects,
List<CommitValidationStatus> statuses) {
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment