feat: Update build process and instructions

Issue #7 (closed)

@malowe @epoirier @oliviergoulet

Don't mind the duplicate commits. I accidentally pushed to master on my fork

requested review from @malowe

requested review from @cguindon, @epoirier, and @oliviergoulet

@zacharysabourin build is failing due to docker not being accessible on Jenkins. We'll need a compile-prod make command that does all of the compilation and cleaning without docker commands. You can probably make it one step if that's easier.

I decided to remove the docker compose down from make clean. My reasoning is that even locally, it won't really be necessary in most cases.

The build has passed :)

I typically have commands for building with jenkins and dev.

You can see an example in my drupal 9 marketplace project:

https://gitlab.eclipse.org/eclipsefdn/it/websites/marketplace.eclipse.org/-/blob/main/Makefile#L55

clean-dev:;
	docker-compose down -v --rmi local
	sudo rm -rf volumes web vendor private-files

clean:;
	rm -rf web vendor private-files

tldr; I added -dev suffix for commands that I expect should only be useful for a developer.

Its more that clean was included in the full deployment, which was the issue. We used the same deployment for Jenkins as we do locally. Technically if you run a full deploy, this just helped make your workspace a bit tidier. We can look at adding that, but I don't think it will provide much value

It's preferable to have commands that work everywhere.

With drupal, building the code within the container vs on our laptop is different. For example, I need to use sudo on my laptop to change file permission but it's not needed in the docker when building the image.

I do you have a use case for splitting them but your project might not. I will defer to you guys on what works best for you.

added 1 commit

• d4c3ae3a - feat: Remove unnecessary docker command

Compare with previous version

approved this merge request

mentioned in commit 16894b89

merged