Gitlab access token for tools.cdt expired?

Summary

I am getting 401 errors from GitHub actions for dash license when trying to automatically create issues.

For example:

Error:  Failed to execute goal org.eclipse.dash:license-tool-plugin:1.1.1-SNAPSHOT:license-check (default-cli) on project org.eclipse.cdt.lsp.root: Execution default-cli of goal org.eclipse.dash:license-tool-plugin:1.1.1-SNAPSHOT:license-check failed: org.gitlab4j.api.GitLabApiException: 401 Unauthorized -> [Help 1]

That came from this GHA run: https://github.com/eclipse-cdt/cdt-lsp/actions/runs/8000156547/job/21849117292

I assume the problem is the token, which IIUC is managed by EF. The token is referenced here:

https://github.com/eclipse-cdt/cdt-lsp/actions/runs/8000156547/workflow#L21

(but https://github.com/eclipse-cdt/cdt is likely to have the same problem)

Steps to reproduce

Run /request-license-review on a PR, such as https://github.com/eclipse-cdt/cdt-lsp/pull/271

What is the current bug behavior?

Getting 401 error

What is the expected correct behavior?

Automatically create the iplab ticket

Relevant logs and/or screenshots

As above

Priority

• Urgent
• High
• Medium
• Low

Severity

• Blocker
• Major
• Normal
• Low

Impact

Not quite sure the impact, we don't have a release for a couple of weeks scheduled, so we can merge with the license failure temporarily if needed.

added IT-prioritymedium IT-severitynormal service:GitHub service:GitLab statetodo team:releng labels

assigned to @fgurr

I'm slightly confused and have to ask the classic question: "(How) has this ever worked?"

I can't see any trace of setup for CDT. There does not seem to be a GitLab bot for CDT and no GITLAB_API_TOKEN is set in GitHub. I also haven't found a HelpDesk issue where the setup was requested.

Hmm - sorry and perhaps it has never worked. Alexander Fedorov (can't find his gitlab handle) added this to CDT in https://github.com/eclipse-cdt/cdt/pull/386

I have run the process locally with my own gitlab token and it works fine and unblocks me.

Can you please change this to add the needed bot and token?

Found his tag @afedorov3un

@afedorov3un - did this ever work?

@jograham when I added this I was not aware of /request-license-review feature, so most probably it was never configured properly for /request-license-review feature, only for regular checks. Sorry for this.

Thanks @afedorov3un - the yaml file in the PR has this gitlabAPIToken: ${{ secrets.GITLAB_API_TOKEN }} so if you have used the pattern elsewhere you may need to request the secret gets created by EF at some point so it works.

@jograham what is the status of this issue? can we close it?

assigned to @heurtemattes

I hadn't had to do a /request-license-review in a while so had forgotten about this. Thanks for the ping @heurtemattes.

Can the GITLAB_API_TOKEN be added for eclipse-cdt org? Not urgent though.

A PR has been created: https://github.com/eclipse-cdt/.eclipsefdn/pull/9

Thanks @heurtemattes for adding a token for us!

This can be closed now I think.

removed statetodo label

closed