Move JDT LS repository to Eclipse JDT Github organization

Project https://projects.eclipse.org/projects/eclipse.jdt.ls is subproject of https://projects.eclipse.org/projects/eclipse.jdt thus please move it's Github repo https://github.com/eclipse/eclipse.jdt.ls/ under Eclipse JDT Github organization https://github.com/eclipse-jdt/ . Discussion with agreement from Project Leads happened at https://github.com/eclipse/eclipse.jdt.ls/issues/2767

This request is in conflict with our rule of having one separate GitHub org per project (similar to the rule about Jenkins instances). We would like to avoid any exceptions to that rule.

So your proposal is to have eclipse-jdtls github org? This sounds fine to me and if this is the case I'll consult with the project leads whether its fine with them.

Strictly speaking, the format of GitHub org names is eclipse-<project_shortname>. So for the project ID eclipse.jdt.ls it would be eclipse-ls.

See also the name of the Jenkins instance: https://ci.eclipse.org/ls/

@akurtakov are you ok with moving forward with the org name eclipse-ls?

added IT-prioritylow IT-severitylow labels

I'm afraid eclipse-ls doesn't work. It reads as "Eclipse Language Server(s)". If that org. were to host multiple language servers, that'd be fine, but I don't think we'll move LemMinX, or even LSP4J there.

eclipse-jdt-ls or eclipse-jdtls work for me

This comes down to allowing a less-than-ideal project short name to exist in the first place (/cc @wbeaton).

I don't see it as a critical problem, since the CI instance had the same short name (https://ci.eclipse.org/ls) and we never had a report about confusion of language servers.

At the same time, I understand that eclipse-jdt-ls or eclipse-jdtls is a preferred org name.

It will most likely break our internal tooling at some point.

I would posit that Github is were people (i.e. users) go to look at code, hardly anyone bothers with the Jenkins instance, so that one is not a big deal (even if I don't like it either).

Let's go with eclipse-jdtls and see what happens.

@fbricon Since GitHub will eventually make 2FA mandatory later this year (see https://github.blog/2023-03-09-raising-the-bar-for-software-security-github-2fa-begins-march-13/), any concerns with enforcing 2FA for the eclipse-jdtls GitHub org?

@fgurr no concerns, go ahead

Ok. Done.

assigned to @fgurr

GitHub org https://github.com/eclipse-jdtls has been created.

The eclipse.jdt.ls repo has been transferred to https://github.com/eclipse-jdtls/eclipse.jdt.ls.

Committers will gain access once the sync script runs (~2-4h).

Thanks Fred

/cc @netomi

@fgurr since the migration it looks like the github pr builder bot no longer comments/adds-a-check on the corresponding PR https://ci.eclipse.org/ls/job/jdt-ls-pr/4476/ -> https://github.com/eclipse-jdtls/eclipse.jdt.ls/pull/2795. Was some config lost in the process?

From the jenkins build log:

07:37:52 FileNotFoundException means that the credentials Jenkins is using is probably wrong. Or the user account does not have write access to the repo.
07:37:52 org.kohsuke.github.GHFileNotFoundException: https://api.github.com/repos/eclipse-jdtls/eclipse.jdt.ls/statuses/96c8c4a4faba51f52f097e7bbe917b26866c67b9 {"message":"Not Found","documentation_url":"https://docs.github.com/rest/commits/statuses#create-a-commit-status"}

Looks indeed like a credential issue. The repo / commit hash look correct.

The eclipse-ls-bot user is not yet member of the new organization.

eclipse-ls-bot is a member of the eclipse-jdtls GitHub org now.

I think this one is done now.

closed