Many old download pages should (probably) be removed

mentioned in issue #1901 (closed)

added ~26502 team:webdev labels

I am a bit confused here on why some links work and some others don't. I was under the impression that we had the responsibility of making all these releases available for download. Is that incorrect?

Is there an archiving process that's happening that I am not aware of?

I do agree with @jograham that we should probably remove them if it's no longer possible to download them but before we take action, I would like to better understand why some of these links no longer work to make sure we are doing the right thing.

added Need More Info label

TL;DR

The broken links are to Milestones and Release Candidates only which are discarded once the Release is made.

Hi @cguindon - the general retention policy (implemented by "Remove the old M and RC builds" step in the EPP release process) is to only keep releases, as a result milestones and release candidates are discarded soon after the final release is made (normally by M1 of the next release).

Note part of the confusion in this area may arise because of the overloading of the word "release". It ends up having two meanings for the Eclipse IDE. Every Milestone and Release Candidate gets "released" aka "published" on the Friday according the the release schedule. A milestone ends up in the "Releases" location on eclipse.org (e.g. https://www.eclipse.org/downloads/packages/release/2022-06/m3). But only the R-build* is actually a release in the EDP sense. I try not to use the word "release" when talking about milestones, but I have found it difficult.

Hopefully that fully clarifies the situation.

* Note that older releases (<= Oxygen) have multiple releases, e.g. R, 1A, 2, etc.

removed Need More Info label

assigned to @cguindon

added statetodo label

@jograham Thanks for the clarifications. Let me rephrase what I think you are asking me to do before we take action:

Once a final release is made, we should redirect milestones and release candidates to the final release. For example, https://www.eclipse.org/downloads/packages/release/2022-06/rc1 should redirect to https://www.eclipse.org/downloads/packages/release/2022-06/r
Each link on https://www.eclipse.org/downloads/packages/release should redirect to the final release with the exception of the current release in developement. For example, 2022-09 should still link to https://www.eclipse.org/downloads/packages/release/2022-09 until tomorrow since that's when we plan on releasing 2022-09 R. Once release, all the milestones and release candidates should redirect to 2022-09 R.

Did I get this right?

* Note that older releases (<= Oxygen) have multiple releases, e.g. R, 1A, 2, etc.

This is an important detail. For older releases (<= Oxygen), can you provide a list of all the releases that we need to keep to ensure that we do this right?

Since there is more than 1 release for these older ones, could you also let me know which one I should use to redirect traffic from milestones and release candidates?

For example, I would assume that we would want to keep R, SR1, and SR2 for Eclipse Indigo. I would also assume that we would want to redirect all the SR*, RC* AND M* releases to SR2? Did I get this right?

@jograham Thanks for the clarifications.

My pleasure.

Let me rephrase what I think you are asking me to do before we take action:

Once a final release is made, we should redirect milestones and release candidates to the final release. For example, https://www.eclipse.org/downloads/packages/release/2022-06/rc1 should redirect to https://www.eclipse.org/downloads/packages/release/2022-06/r

Yes. Also I think that https://www.eclipse.org/downloads/packages/release/2022-06 will have little value (just the link to R) so it could be set to redirect too.

Each link on https://www.eclipse.org/downloads/packages/release should redirect to the final release with the exception of the current release in developement. For example, 2022-09 should still link to https://www.eclipse.org/downloads/packages/release/2022-09 until tomorrow since that's when we plan on releasing 2022-09 R. Once release, all the milestones and release candidates should redirect to 2022-09 R.

Yes. (With exception listed below for <= Oxygen)

Did I get this right?

Yes.

* Note that older releases (<= Oxygen) have multiple releases, e.g. R, 1A, 2, etc.

This is an important detail. For older releases (<= Oxygen), can you provide a list of all the releases that we need to keep to ensure that we do this right?

Since there is more than 1 release for these older ones, could you also let me know which one I should use to redirect traffic from milestones and release candidates?

I think you should redirect to the release's page.

For example, I would assume that we would want to keep R, SR1, and SR2 for Eclipse Indigo. I would also assume that we would want to redirect all the SR*, RC* AND M* releases to SR2? Did I get this right?

For your example, I think you should redirect to /indigo in this case (i.e. release/indigo/m7 -> release/indigo)

Here is the complete list of valid builds:

Two final notes on this subject:

I don't know how much value there is at all in these old pages. The important part, the downloads themselves are retained on https://archive.eclipse.org/technology/epp/downloads/release/ . Other companies don't keep the flashy pages around for releases that are so old.
There is a minor error on all the non /r pages, they are incorrectly listed as a Developer Build:

I don't know how much value there is at all in these old pages.

I think it may be best to just get rid of all pages before the numbered releases. Let me check around and get back to you. It feels like spending time fixing these old pages is wasted when they probably should just be deleted.

I sent something to planning council to check - hopefully I will have a reply soon - https://www.eclipse.org/lists/eclipse.org-planning-council/msg03603.html

Sounds good! I will wait for you to get back to us before starting to work on an implementation plan to fix this.

I think the conclusion is to not edit the old pages (< 2018-09) or spend any more time working on them, just remove links to them from https://www.eclipse.org/downloads/packages/release

For the other pages (>= 2018-09) the updates as discussed above are desired. I think by doing this version range means no special cases, so hopefully that simplifies things.

Thanks, @jograham for the clarifications!

@epoirier Can you take this on next week please?

assigned to @epoirier

unassigned @cguindon

added prioritymedium severitynormal labels

added statereview label and removed statetodo label

@jograham I created a merge request to update the SQL query that fetches the information on the Releases page.

https://gitlab.eclipse.org/eclipsefdn/it/webdev/drupal/packaging_features/-/merge_requests/12

Here is a screenshot of what it looks like currently on my local.

Let me know if I'm missing something.

Thanks.

Eric, did you take into consideration that we need to display developer's links (milestones and rc) for 2023-03 until its release?

I am assuming you have an old copy of the database since the page is missing all the 2022 releases..?

That looks good @epoirier, it is good that the old releases are not listed.

for 2023-03 until its release?

We're still working on 2022-12. Right now we have no developer releases available, first one is scheduled for next Thursday/Friday.

I am assuming you have an old copy of the database since the page is missing all the 2022 releases..?

Also the "Eclipse Installer 2021-03 R [...]" link on the right doesn't match even the latest in your list on the left. The current live webpage looks right, so I assume that this is also an artifact of dev environment?

@cguindon My understanding is that M and RC releases are being displayed on the release page itself.

Example: /release/2022-09

But with my changes, I'm fetching all releases given that they have been created after July 23, 2018.

Yes my database is pretty old, didn't think I needed a fresh copy for what I needed to do here.

@jograham My screenshot was simply to give an idea of what items I removed from the list. I can definitly update my local database to show the exact list that we will see on production once my changes are live.

Thanks @epoirier - looks good to me then. Let me know when it is live and I will have a look. I can't see the MR you linked to because I assume I don't have such permissions.

changed due date to October 31, 2022

mentioned in issue eclipsefdn/it/websites/eclipse.org#118 (closed)

Hi @jograham,

The releases page have been cleaned up on production.

https://www.eclipse.org/downloads/packages/release

When an R release is available, the links are redirecting to that page. If not, a new page opens to let you choose the release version (just like it was before).

Let me know if there's anything else.

Thanks.

closed

Thanks @epoirier - looks great.

There is one small issue I noticed. When a redirect from an M or RC build sends to the R page, the Please note that this is a developer build which might contain issues. is still shown.

i.e. click on: https://www.eclipse.org/downloads/packages/release/2022-09/rc1 and you get this:

Also, on the redirected page the Search in the upper-right is present, in direct it is not present:

Finally, the link to directly download the installer on the right seems correct when redirected (left side) but incorrect when directly visiting (right side). I am on linux, and the links on the left are for linux, on the right are for windows.

Here is the diff of a prettified version of the HTML with redirect and without

diff -u redirect.html direct.html  
--- redirect.html	2022-10-11 09:09:23.467163354 -0400
+++ direct.html	2022-10-11 09:09:23.751164730 -0400
@@ -67,7 +67,7 @@
         setHasJsCookie: 0,
         ajaxPageState: {
           theme: "solstice_packages",
-          theme_token: "qFKLbCteDnTLnN52ugE39txlL78iIKPwWt1OomLdc-k",
+          theme_token: "lVwAyEH0N2oDZaLufde9VwyjchaTMp4GRhJiPCKjfog",
           js: {
             "public:\/\/google_tag\/google_tag.script.js": 1,
             "\/\/ajax.googleapis.com\/ajax\/libs\/jquery\/1.10.2\/jquery.min.js": 1,
@@ -394,62 +394,6 @@
                       </li>
                     </ul>
                   </li>
-                  <li class="dropdown eclipse-more main-menu-search">
-                    <a
-                      data-toggle="dropdown"
-                      class="dropdown-toggle"
-                      role="button"
-                      aria-label="Open Google Search menu"
-                      ><i class="fa fa-search"></i> <b class="caret"></b
-                    ></a>
-                    <ul class="dropdown-menu">
-                      <li>
-                        <!-- Content container to add padding -->
-                        <div class="yamm-content">
-                          <div class="row">
-                            <div class="col-sm-24">
-                              <p>Search</p>
-                              <div class="row">
-                                <div class="col-md-24">
-                                  <div
-                                    id="custom-search-form"
-                                    class="reset-box-sizing"
-                                  >
-                                    <script>
-                                      (function () {
-                                        var cx =
-                                          "011805775785170369411:p3ec0igo0qq";
-                                        var gcse =
-                                          document.createElement("script");
-                                        gcse.type = "text/javascript";
-                                        gcse.async = true;
-                                        gcse.src =
-                                          (document.location.protocol ==
-                                          "https:"
-                                            ? "https:"
-                                            : "http:") +
-                                          "//cse.google.com/cse.js?cx=" +
-                                          cx;
-                                        var s =
-                                          document.getElementsByTagName(
-                                            "script"
-                                          )[0];
-                                        s.parentNode.insertBefore(gcse, s);
-                                      })();
-                                    </script>
-                                    <gcse:searchbox-only
-                                      gname="main"
-                                      resultsUrl="https://www.eclipse.org/home/search"
-                                    ></gcse:searchbox-only>
-                                  </div>
-                                </div>
-                              </div>
-                            </div>
-                          </div>
-                        </div>
-                      </li>
-                    </ul>
-                  </li>
                 </ul>
               </div>
               <div class="navbar-header">
@@ -567,13 +511,6 @@
             role="complementary"
             class="col-md-18 col-sm-16 margin-bottom-20"
           >
-            <div class="alert alert-block alert-warning messages warning">
-              <a class="close" data-dismiss="alert" href="#">&times;</a>
-              <h4 class="element-invisible">Warning message</h4>
-              Please note that this is a <strong>developer build</strong> which
-              might contain issues.
-            </div>
-
             <div
               class="region region-content-top solstice-region-element-count-1 margin-top-20 margin-bottom-20"
             >
@@ -1920,16 +1857,10 @@
                     <p>
                       <a
                         class="btn btn-warning margin-bottom-5"
-                        href="https://www.eclipse.org/downloads/download.php?file=/oomph/epp/2022-09/R/eclipse-inst-jre-linux64.tar.gz"
+                        href="https://www.eclipse.org/downloads/download.php?file=/oomph/epp/2022-09/R/eclipse-inst-jre-win64.exe"
                         title="x86_64 Download"
                         >Download x86_64</a
                       >
-                      <a
-                        class="btn btn-warning margin-bottom-5"
-                        href="https://www.eclipse.org/downloads/download.php?file=/oomph/epp/2022-09/R/eclipse-inst-jre-linux-aarch64.tar.gz"
-                        title="AArch64 Download"
-                        >Download AArch64</a
-                      >
                     </p>
                     <p>

Because of the last item, the download link being incorrect, I am reopening this issue. I don't know if this is a regression caused by this change or something I simply never noticed before. Let me know if you prefer I submit this is a new issue.

Hi @jograham, thanks for the feedback, I'll have a look at those issues.

I created a merge request to fix the warning message being printed on the wrong page.
From what I can see the search only appears on the developer build page. I'll have to investigate.
I can't reproduce this locally but I do see the issue on production. The reason why you're seeing Windows links is because Windows is the default in our code. I'll need to investigate this further as well. Note that when I login as an admin on the packaging website, I do see the proper links (Linux for me). But when I'm viewing the site as an anonymous user, I see a Windows link in the installer block.

Will keep you posted on what I find out.

@jograham I fixed the warning messages not being shown at the right place.

@jograham the Installer in the sidebar is now fixed as well.

I'll look into the search now.

reopened

@jograham @epoirier,

I see that issue was re-opened, what's remaining on this issue?

@cguindon I think it was reopened to look into the sidebar and the search but I believe we took care of those issues when updating the caching in the sidebar and we merged a commit to update the search form in the menu.

I think I simply forgot to close this issue when we did this 2 weeks ago.

@jograham can you confirm all is good with the changes that we made?

Thanks.

There are still some pages where the search doesn't appear (for me), e.g. https://www.eclipse.org/downloads/packages/release/2022-12/m2 so there is still some inconsistency in that regard. This is minor and marginal, please feel free to split it out to a new issue as the main purpose of this issue is fully resolved.

Thank you for cleaning all this up!

Hi @jograham,

I created the following issue to track the search bar problem.

eclipsefdn/it/websites/eclipse.org#209 (closed)

I'll keep you posted over there once we find the solution.

Thanks!

Thank you @epoirier!

closed

Many old download pages should (probably) be removed

Summary

Steps to reproduce

What is the current bug behavior?

What is the correct behavior?

Designs

Child items ...

Activity