[oniro] Mirror repositories doesn't work

Summary

I created several projects with mirror option, located at https://gitlab.eclipse.org/eclipse/oniro-core/third-party but they don't seem to be updating and aren't visible in Settings->Repository-Mirroring repositories, so I cannot force update nor change settings for the mirrors.

I tested the functionality in gitlab.com and it looks like they need to be added additionally in settings. Unfortunately I'm unable to do it. According to gitlab.com docs I should be Maintainer, and I am, but the setting seem to be restricted to admin.

Related to #1532 (comment 913911)

Steps to reproduce

Create new project as import project and "Repository by URL". Then add https://git.seco.com/pub/i.mx/yocto/5.x/meta-seco-imx.git as git repository URL and tick "Mirror repository". After successful project creation go to Settings->Repository-Mirroring repositories There will be empty "Mirrored repositories" list. Just add again https://git.seco.com/pub/i.mx/yocto/5.x/meta-seco-imx.git

What is the current bug behavior?

Unable to add the same repo in Settings->Repository-Mirroring repositories after creation of the project.

What is the expected correct behavior?

I should be able to add the same repository again via Settings->Repository-Mirroring repositories

Relevant logs and/or screenshots

added Blocker ~16083 labels

changed the description

added IT-prioritymedium IT-severitynormal statetodo team:releng labels

Since the user that sets up the mirroring will become the "Mirror user" ("You will be the author of all events in the activity feed that are the result of an update, like new branches being created or new commits being pushed to existing branches."), I wonder if it should be rather the "Eclipse Webmaster" or "Eclipse Genie" account that sets this up.

/cc @droy

@droy @fgurr since mirroring will cause commits to the repo (ECA!) shouldn't it be really the user who sets up mirroring and not yet another (presumably) the same global user/bot ?

IIUC

• If I set this up, I will be the author of all updates (commits, etc.)
• If you set this up (with the appropriate permissions) you will be the author of all updates (commits, etc.)

My question was, if this should not be a generic account like "Eclipse Webmaster", "Eclipse Genie" or a bot user like "Oniro Core Bot user" instead.

I don't know yet, if the "mirror user" will always need admin access to commit updates, etc.

Side note: I was not aware that mirroring (pulling in changes from a remote repo) needs to involve a "mirror user" at all.

Are you sure mirroring invokes the GitLab hooks?

I wouldn't mind trying this with the webmaster account. FWIW, the EF has never, ever been a mirror of any other repository. Since we'd be mirroring third party code, we'd have to vet mirrored repos one by one, in conjuction with the EMO/IP team.

If you can point me to one repo, I'll use the webmaster account to enable mirroring and we can see how it goes?

Ping @pastanki

For now we would like to mirror repositories:

https://git.seco.com/pub/i.mx/yocto/5.x/meta-seco-imx
https://git.seco.com/pub/intel/yocto/meta-seco-intel
https://git.seco.com/pub/rockchip/meta-seco-rockchip

Right now they are set here

From what I noticed, commits authors are already mapped somehow either to local users (if exists) or to external email ?

@wbeaton Please see @pastanki comment above. As the EF has never, ever been a mirror of any other repository before, how do you suggest we proceed for mirroring third party repos into our GitLab?

If I set this up, I will be the author of all updates (commits, etc.)

The account is used to be the committer of the push but the author is preserved while mirroring updates. Like tags are pushed in gitlab, but reference tag author tagger is preserved too.

Are you sure mirroring invokes the GitLab hooks?

Don't find any documentation related. I assume it's not invoked on sync.

The account is used to be the committer of the push but the author is preserved while mirroring updates. Like tags are pushed in gitlab, but reference tag author tagger is preserved too.

I have not tested it and the GitLab documentation might be vague or inaccurate, but it states:

You will be the author of all events in the activity feed that are the result of an update, like new branches being created or new commits being pushed to existing branches.

Can be seen at https://gitlab.eclipse.org/eclipse/oniro-core/third-party/mirrors/meta-seco-imx/-/settings/repository -> Mirroring Repositories -> Mirror user

That should only "affect" the activity feed. In terms of git commits, this shouldn't have any impact (we should check though but I would be very surprised if that is not the case).

changed title from Mirror repositories doesn't work to [oniro] Mirror repositories doesn't work

mentioned in issue eclipse/oniro-core/oniro#471

assigned to @fgurr

assigned to @wbeaton

@heurtemattes - could you take over the issue and discuss with Oniro this is still needed ?

assigned to @heurtemattes

@agherzan can you confirm Oniro interest for this feature?

Absolutely. We maintain a good couple of mirrors and being able to have refreshed upstream branches would be useful.

@agherzan can you propose a first project to mirror, next an existing one and see if it meets all expectations?

I'm happy to start with meta-zephyr.

Can you check https://gitlab.eclipse.org/eclipse/oniro-core/third-party/mirrors/meta-zephyr?

All first activities were made with my account. I had to change in gitlab rails console mirror user.

svc_user = User.find_by(username: 'oniro-core-bot')
project = Project.find_by_full_path('eclipse/oniro-core/third-party/mirrors/meta-zephyr')
project.mirror_user = svc_user
project.save

See change effect:

Looks good. What is the policy of refs that are in the destination but not upstream (and the other way around)?

@agherzan there is mirroring options I didn't check. If this is you"re asking for.

Like Keep divergent refs and Mirror only protected branches Feel free to change this behavior if needed.

https://gitlab.eclipse.org/eclipse/oniro-core/third-party/mirrors/meta-zephyr/-/settings/repository

@agherzan I propose to close this issue. For any further mirroring request feel free to open new helpdesk issues.

closed