Skip to content
Snippets Groups Projects

Add street_name into LogicalLane

osi::LogicalLane has field std::string street_name, but map_api::LogicalLane hasn't

The goal of this MR is to fix mismatching of interfaces between OSI and map_api

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Xiao Pan approved this merge request

    approved this merge request

  • Fine for me.

  • Daniil Nikulin marked this merge request as ready

    marked this merge request as ready

  • Hi @daniilnikulin , are there any other differences between the current MapAPI and OSI 3.7? Could you please double-check? Since this is an interface used across multiple repos, it would be nice to keep it as constant as possible. Ideally limiting changes to one after an OSI update. Thanks!

  • Hi @xiaopan

    I found these relevant changes from OSI 3.5.0 to OSI 3.7.0

    • new field ReferenceLine::type (map_sdk already has it)

    • new field RererenceLinePoint::t_axis_yaw (map_sdk already has it)

    • new field LogicalLane::street_name (current MR)

    • new field LogicalLane::traffic_rule

    • Deprecated StationaryObject::Classification::Material::MATERIAL_GLAS (use MATERIAL_GLASS instead)

    • Deprecated StationaryObject::Classification::Color::COLOR_GREY (use COLOR_GRAY instead)

    • Deprecated type osi3::StationaryObject::Classification::Color (use osi3::ColorDescription instead)

    • Extended enum osi3::TrafficSign::Variability

    Edited by Daniil Nikulin
  • PS:

    there are another changes, but they aren't relevant for map-sdk

    example: changes in osi3::HostVehicleData , osi3::MovingObject or osi3::LidarDetection

    Edited by Daniil Nikulin
  • Andreas Rauschert approved this merge request

    approved this merge request

  • mentioned in commit ddd79fb5

Please register or sign in to reply
Loading