EntityProperties is not list/aggregate initializable

EntityProperties has a user-defined defaulted virtual destructor despite being a simple data structure (no other methods).

struct EntityProperties {
  virtual ~EntityProperties() = default;
  // ...
};

This makes it and all classes that inherit from it (PedestrianProperties, StaticObjectProperties, VehicleProperties) non-aggregate types, meaning the only permitted constructors are user-defined and default constructors, and none of them have user-defined constructors.

In their current state, these classes produce unnecessary boilerplate code and twice as many assignments as needed. The virtual destructor should be removed, as it serves no purpose.

added Enhancement label

changed the description

Maybe it would make sense to switch from inheritance to composition just to make sure, that no memory leaks occur when deleting derived property structs through a base class pointer:

struct VehicleProperties {
  EntityProperties entity_properties;
  // ...
};

In IEntityRepository the derived types are used explicitly, anyway.

Ah, I see. So that's why the virtual destructor exists. Turns out there are a total of three pure data structs with a virtual destructor: EntityProperties, ControlStrategy and IControllerConfig. Deletion via a base class pointer seems more common for the latter two.

The best solution in my eyes would be to provide constructors for each of these classes and their inheritors.

This preserves the benefits of the current implementation while solving the issue of inefficient construction.

changed the description

mentioned in merge request !155 (merged)

mentioned in commit 2ab14382

closed with merge request !155 (merged)