Skip to content
Snippets Groups Projects

Draft: flutter: Add layer

Closed philippe coval requested to merge pcoval/oniro:sandbox/rzr/review/main into kirkstone
2 unresolved threads

This revision belong to honister branch and it has been checked on onrio kirkstone base using downstream project meta-oniro-blueprint-flutter.

Relate-to: https://gitlab.eclipse.org/groups/eclipse-wg/oniro-wg/proposal-incubation-stage-oniro/-/wikis/UI Origin: https://booting.oniroproject.org/distro/oniro/-/merge_requests/541 Forwarded: https://gitlab.eclipse.org/eclipse/oniro-core/oniro/-/merge_requests?scope=all&state=opened&author_username=pcoval Signed-off-by: Philippe Coval philippe.coval@huawei.com

Edited by philippe coval

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
24 24 LAYERSERIES_COMPAT_oniro-core = "honister"
25 25
26 26 ONIRO_COREBASE = '${@os.path.normpath("${LAYERDIR}/../")}'
27
28 # Needed for meta-flutter
29 FLUTTER_SDK_TAG ?= "2.10.2"
  • Shouldn't this be a distro configuration? I know it would work from layer.conf but it introduces information that doesn't seem to belong there. Also, why is this tag needed in the first place? Isn't there a default TAG provided by the flutter layer? Out of curiosity, why do you need the Relate-to footers? And if you do, why aren't they in the same block with the SoB footer? I'm asking because I think some tools assume that git log footers are in the same block.

  • Author Developer

    if it's not in distro it could break anyway at parsing time, anyway i will drop this change because upstream pinned version since.

    I am using the habit to track my patches then if there is need to investigate about the context it will save me time, and footers are are in the same block it's only gitlab formating.

  • OK. Please update the MR in that case. Does it have an Epic/Issue associated?

  • Please register or sign in to reply
  • Andrei Gherzan
    Andrei Gherzan @agherzan started a thread on commit 56f8eb24
  • 19 19 ##OEROOT##/../meta-freertos \
    20 20 ##OEROOT##/../meta-intel \
    21 21 ##OEROOT##/../meta-seco-intel \
    22 ##OEROOT##/../meta-flutter \
  • philippe coval marked this merge request as draft

    marked this merge request as draft

  • I'll close this for now. Looking forward to reopening it when we get it out of draft mode.

  • philippe coval mentioned in merge request !338 (closed)

    mentioned in merge request !338 (closed)

  • Please register or sign in to reply
    Loading