#596 PLCgen: improve classification of automata roles

• This merge request is an attempt to resolve this discussion: !619 (comment 1194262).
• Note that the target of the merge is the branch of !619 (merged). This merge request should thus be merged into that merge request, before that merge request is merged into develop.
• I'll explain the changes in the referred discussion.

Addresses #596 (closed)

changed milestone to %v1.0

added CIF TypeEnhancement labels

mentioned in merge request !619 (merged)

changed title from #596 (closed) Classify automata, not edges. to #596 (closed) PLCgen: improve classification of automata roles

Improved the merge request title.

Really nice work, I like the idea of "role classification".

Thanks!

approved this merge request

I can't merge this one, as the build fails. Something with the tests. @ahofkamp Could you take over, fix the tests, and merge this?

Ah, you were ahead of me. Let me see.

Looking at the build, plcgen tests seem broken.

15:11:10  Failures: 
15:11:10    CifTest.testCifPlcGen:150->ToolDefBasedPluginUnitTest.test:56 24 tests failed. See console output for details.

Looking at the build of the parent MR, seemingly it fails on a too old maven version.

09:46:11  [INFO] --- maven-clean-plugin:2.5:clean (default-clean) @ org.eclipse.escet.releng.configuration ---
09:46:11  [INFO] 
09:46:11  [INFO] --- maven-enforcer-plugin:3.0.0:enforce (enforce-versions) @ org.eclipse.escet.releng.configuration ---
09:46:11  [WARNING] Rule 1: org.apache.maven.plugins.enforcer.RequireMavenVersion failed with message:
09:46:11  Detected Maven Version: 3.8.6 is not in the allowed range 3.9.0.
09:46:11  [INFO] ------------------------------------------------------------------------
09:46:11  [INFO] Reactor Summary for org.eclipse.escet.root 1.0.0-SNAPSHOT:
09:46:11  [INFO] 
09:46:11  [INFO] org.eclipse.escet.releng.configuration ............. FAILURE [  2.438 s]
09:46:11  [INFO] org.eclipse.escet.root ............................. SKIPPED
09:46:11  [INFO] [aggregator] chi ................................... SKIPPED
09:46:11  [INFO] [aggregator] common ................................ SKIPPED
09:46:11  [INFO] [bundle] ESCET Common EMF Ecore XMI Resource Factory (Incubation) SKIPPED

I am fine with merging your branch into mine (just fast-forwarding would work too).

No idea how to fix that error though. I am guessing updating to current develop.

added 1 commit

• e5056362 - #596 (closed) Fix test output.

Compare with previous version

merged

mentioned in commit 0ce44d00

mentioned in merge request !625 (merged)