Upgrade AsciiDoctor Maven plugin versions
There are various new version of AsciiDoctor-related plugins, including new major versions, see https://github.com/asciidoctor/asciidoctor-maven-plugin/releases/tag/asciidoctor-maven-tools-3.0.0. We should upgrade.
Previous attempt
I tried a less aggressive upgrade, around early this year, while working on the styling and collapsible TOC, etc, in #38:
- I used this patch: asciidoctor_version_upgrades.patch
- I generated the website using
develop
and the patched version, and did a diff. I found various issues in the new version:- Syntax highlighting coderay CSS has some updates. Need to check whether/how that affects us (our overridden CSS).
- ToolDef
DOUBLETK
-<code>(0|[1-9][0-9]*)(\.[0-9]+|(\.[0-9]+)?[eE][\-\+]?[0-9]+)</code>. +<code>(0|[1-9][0-9]*)(\.[0-9]|(\.<span class="0-9">)?[eE][\-\</span>]?<span class="0-9">)</span></code>.
- Development documentation, upgrade version:
-regex <code>org\.eclipse\.escet\.([a-z0-9\.]+);bundle-version="<old-version>"</code> by <code>org. +regex <code>org\.eclipse\.escet\.([a-z0-9\.]);bundle-version="<old-version>"` by `+org
- Development documentation, rail diagrams identifier syntax:
-Defined by the regular expression: <code>[\-A-Za-z0-9_]+</code>. +Defined by the regular expression: <code><span class="\-A-Za-z0-9_">`.
-They thus consist of dashes (<code>-</code>), letters, digits and underscores (<code>_</code>).</p> +They thus consist of dashes (`-`), letters, digits and underscores (`+_</span></code>).</p>
- CIF
REALTK
-<code>(0|[1-9][0-9]*)(\.[0-9]+|(\.[0-9]+)?[eE][\-\+]?[0-9]+)</code>. +<code>(0|[1-9][0-9]*)(\.[0-9]|(\.<span class="0-9">)?[eE][\-\</span>]?<span class="0-9">)</span></code>.
- CIF to mCRL2:
-(<code>+*</code> adds all variables, then <code>-B.*</code> removes all variables that start with <code>B.</code>, that is all variables in automaton <code>B</code>.)</p> +(<code>*` adds all variables, then `-B.*+</code> removes all variables that start with <code>B.</code>, that is all variables in automaton <code>B</code>.)</p>
-addition (<code>+</code>) on integer operands, subtraction (<code>-</code>) on integer operands +addition (<code>`) on integer operands, subtraction (`-`) on integer operands
-multiplication (`*`) on integer operands, integer division (`div`), +multiplication (<code>*</code>) on integer operands, integer division (<code>div</code>),
-integer modulus (<code>mod</code>), equality (<code>=</code>) +nteger modulus (`mod`), equality (`=`)
-nequality (<code>!=</code>) +nequality (`!=`)
-<code><</code>) on integer operands, less than or equal to (<code><=</code>) +(`<`) on integer operands, less than or equal to (`⇐+</code>)
- We should be able to solve these issues with better escaping in our AsciiDoc source files, but I did not investigate that at the time.
- Other things to try:
- Can we omit JRuby explicitly now? See https://github.com/asciidoctor/asciidoctor-maven-plugin/releases/tag/asciidoctor-maven-plugin-2.2.5.
- Can we omit the
jvm.config
now? See https://github.com/asciidoctor/asciidoctor-maven-plugin/issues/553.