Skip to content
Snippets Groups Projects

feat/script_compare_layers_aidge_onnx

All threads resolved!

Context

Since I had problems isolating the issue in a network I wrote with the help of @hrouis a little script that compares layer per layer, the output of an onnx network and its aidge equivalent.

This script is purposed to be called as a function or as a standalone tool so it can be easily be integrated to tests later on.

It misses some small features such as support for nodes with multiple different output and creation of inputs for network with multiple inputs. other than that I feelit doesn't need much more. If you see any feature that needs to be added feel free to tell me.

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Cyril Moineau
  • Good util script !

    I was a little sceptical about the use of ``find_node_with_name```as I thought we could use dictionnary, but change is not trivial and the code lgtm. Let's not over complicate things :)

    Also I think we should move onnx2aidge_name in utils.py and update utils script to use this.

    This way if we identify a new caracter we do not support, we will not have to modify two functions.

  • added 1 commit

    • 3e07d0ac - feat : new "save graph" functionnality

    Compare with previous version

  • Grégoire Kubler added 6 commits

    added 6 commits

    • 2ad5f20a - feat : adding support for GlobalAveragePooling operator
    • 0284e294 - Merge branch 'memorize' into feat/operator_globalAveragePooling
    • 81a19a97 - feat : support for GlobalAveragePooling
    • ebd439bb - Merge remote-tracking branch 'EclipseRepo/dev' into feat/operator_globalAveragePooling
    • ea0508e4 - Merge branch 'feat/operator_globalAveragePooling' into feat/script_compare_layers_aidge_onnx
    • 26361cbe - chore : moved onnx_to_aidge_name to utils.py + formatting

    Compare with previous version

  • added 1 commit

    • e0a33988 - chore : changed success message

    Compare with previous version

  • Author Developer

    :warning: warning

    I resolved thread but merged with !30 (merged) for testing purpose. hence, this MR must be done before merging here.

  • Grégoire Kubler
  • added 1 commit

    • 0e98557f - chore : refactored onnx_to_aidge_name to replace the "replace" function

    Compare with previous version

  • added 1 commit

    • 168adfa7 - chore : refatored function name and added docstring

    Compare with previous version

  • added 3 commits

    Compare with previous version

  • Grégoire Kubler mentioned in issue #11

    mentioned in issue #11

  • added 12 commits

    Compare with previous version

  • @cmoineau or @pineapple MR done, ready for merge after !30 (merged) is done.

  • requested review from @cmoineau

  • Cyril Moineau resolved all threads

    resolved all threads

  • Every thread are closed, I validate and run the MR :smile: Good job @gregkub !

  • Cyril Moineau approved this merge request

    approved this merge request

  • Cyril Moineau added 11 commits

    added 11 commits

    • 4d5527ba - 1 commit from branch eclipse/aidge:dev
    • 8b7eb8b0 - feat : script for layer comparison created
    • aec5fa0c - feat : added doc, some type hint and repurposed the script to be able to call...
    • 3d8ccac3 - chore : code cleanup + function arg type hint
    • eb62057f - feat : new "save graph" functionnality
    • 7b59eeb3 - chore : moved onnx_to_aidge_name to utils.py + formatting
    • 1d969af5 - chore : changed success message
    • dfdabc66 - chore : refactored onnx_to_aidge_name to replace the "replace" function
    • 4ec6826d - chore : refatored function name and added docstring
    • e6fdc573 - chore : renamed function
    • f54ee318 - fix : inverted conditions on onnx2aidge_name

    Compare with previous version

  • Cyril Moineau enabled an automatic merge when the pipeline for f54ee318 succeeds

    enabled an automatic merge when the pipeline for f54ee318 succeeds

  • Cyril Moineau mentioned in commit b0f733f0

    mentioned in commit b0f733f0

  • Please register or sign in to reply
    Loading