Skip to content
Snippets Groups Projects

Adding MatMul operator

Merged Matthew Newson requested to merge mnewson/aidge_export_cpp:MatMul into dev
All threads resolved!

Context

While trying to export the ConvNeXt onnx model to cpp, we encountered several issues. we needed to add broadcasting support for the matmul operator.

  • matmul.hpp add broadcasting for matmul;

  • matmul_config.jinja, and matmul_forward.jinja to include for matmul operator;

    operator.py , register matmul operator;

  • test_export.cpp, add unit tests;

Detailed major modifications

Add matmul broadcasting and unit tests.

TODO

Added matmul broadcasting for exporting ConvNeXt model with aidge_export_cpp;

  • NOT DONE
  • DONE
  • TO DO

Merge request reports

Merged results pipeline #76204 passed with warnings

Merged results pipeline passed with warnings for f971f66b

Approved by
Code Quality is loading
Test summary results are being parsed

Merged by Olivier BICHLEROlivier BICHLER 1 week ago (Jun 19, 2025 3:01pm UTC)

Merge details

  • Changes merged into dev with 03009d35.
  • Deleted the source branch.
  • Auto-merge enabled

Pipeline #76368 passed with warnings

Pipeline passed with warnings for 03009d35 on dev

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Cyril Moineau
  • Cyril Moineau requested changes

    requested changes

  • Matthew Newson added 102 commits

    added 102 commits

    • 26f6458b...f95277a8 - 92 earlier commits
    • 9c729bff - Improve example script test to show stdout in failing cases.
    • af97383b - Fixed missing operators
    • 6f41e44a - Changed skip to expectedFailure
    • f796654c - Fixed Transpose
    • a3fd60a4 - Fixed reshape
    • ead74936 - Update 0.3.0 -> 0.3.1
    • a227c91d - [Refactor] New operators format (operators.py -> [operator_name].py) for the following operators :
    • 8f7acfae - Add broadcasting for matmul and unit tests
    • 6350d174 - adding previous unit tests
    • 58767c65 - Add activation and rescaling

    Compare with previous version

  • Matthew Newson added 14 commits

    added 14 commits

    • 58767c65...c35b6eea - 4 earlier commits
    • c1cc47fa - Debug includes deleted and omp modification
    • 36f54bae - Add erf operators and unit tests
    • 49561d33 - Test export now clean successfull tests.
    • 796d9288 - Add broadcasting for matmul and unit tests
    • 8f2fbcad - adding previous unit tests
    • 71fa08f0 - [Chore] Temporarily comment the save_outputs generated code
    • d6c6ce37 - [Feat] Add int8 support
    • b36348b8 - [Refactor] Split rescaling.hpp and activation.hpp into two types of files :
    • b6679cc9 - Add broadcasting for matmul and unit tests
    • 9c4abace - adding previous unit tests

    Compare with previous version

  • Matthew Newson added 100 commits

    added 100 commits

    • 9c4abace...52348ca9 - 99 commits from branch eclipse/aidge:dev
    • 3566c343 - Merge branch 'dev' of https://gitlab.eclipse.org/eclipse/aidge/aidge_export_cpp into MatMul

    Compare with previous version

  • Matthew Newson added 1 commit

    added 1 commit

    Compare with previous version

  • Matthew Newson added 1 commit

    added 1 commit

    • 8b9a9a1d - Add rescaling and unit tests for matmul

    Compare with previous version

  • Matthew Newson resolved all threads

    resolved all threads

  • Matthew Newson resolved all threads

    resolved all threads

  • @mnewson Please rebase.

  • Olivier BICHLER mentioned in merge request !33 (closed)

    mentioned in merge request !33 (closed)

  • Matthew Newson added 25 commits

    added 25 commits

    • 8b9a9a1d...520348e5 - 23 commits from branch eclipse/aidge:dev
    • 9263f2ef - Merge branch 'dev' of https://gitlab.eclipse.org/eclipse/aidge/aidge_export_cpp into MatMul
    • 9ffbb22f - Merge branch 'MatMul' of gitlab.eclipse.org:mnewson/aidge_export_cpp into MatMul

    Compare with previous version

  • Matthew Newson added 3 commits

    added 3 commits

    • 9ffbb22f...8f876b0b - 2 commits from branch eclipse/aidge:dev
    • 6efdddc2 - Merge branch 'dev' of https://gitlab.eclipse.org/eclipse/aidge/aidge_export_cpp into MatMul

    Compare with previous version

  • Matthew Newson added 2 commits

    added 2 commits

    • dd7463f3 - 1 commit from branch eclipse/aidge:dev
    • 8d6911af - Merge branch 'dev' of https://gitlab.eclipse.org/eclipse/aidge/aidge_export_cpp into MatMul

    Compare with previous version

  • Olivier BICHLER added 13 commits

    added 13 commits

    Compare with previous version

  • Olivier BICHLER bypassed reviews on this merge request

    bypassed reviews on this merge request

  • Olivier BICHLER enabled an automatic merge when all merge checks for 03009d35 pass

    enabled an automatic merge when all merge checks for 03009d35 pass

  • Olivier BICHLER approved this merge request

    approved this merge request

  • Please register or sign in to reply
    Loading