In the getConvHorizontalTiling()
function used in the HorizontalTiling
recipe, Concat and Slice nodes were not named.
It is right that a node is not meant to be defined by its name and it is thus not a mandatory attribute. However, having specified node names as shown to be useful for further graph manipulations, such as for memory mapping features.
Original Graphview before tiling:
Modified Graphview after Conv_1
tiling, before this MR:
Modified Graphview after Conv_1
tiling, with naming technique proposed in this MR:
aidge_core/src/recipes/HorizontalTiling.cpp
, to explicit set names to Concat, Slice and Slice's Producers nodes.Added a generic name to Concat nodes:
concat -> setName(concat->type());
Added a generic name to Slice nodes, while keeping track of the original (Conv) node they are linked to (i.e. node->name
):
slice -> setName(node->name() + '_' + slice->type() + '_' + std::to_string(i));
Added an underscore in the names of Slices' Producers nodes for readability:
auto startsNode = Producer(starts, slice->name() + "_" + sliceInputsNames[1]);
Copyright © Eclipse Foundation, Inc. All Rights Reserved. Privacy Policy | Terms of Use | Copyright Agent