Add explicit names setting to nodes created in the HorizontalTiling recipe

Context

In the getConvHorizontalTiling() function used in the HorizontalTiling recipe, Concat and Slice nodes were not named.

It is right that a node is not meant to be defined by its name and it is thus not a mandatory attribute. However, having specified node names as shown to be useful for further graph manipulations, such as for memory mapping features.

Illustration:

Original Graphview before tiling:

Modified Graphview after Conv_1 tiling, before this MR:

Modified Graphview after Conv_1 tiling, with naming technique proposed in this MR:

Modified files

• aidge_core/src/recipes/HorizontalTiling.cpp, to explicit set names to Concat, Slice and Slice's Producers nodes.

Detailed major modifications

Added a generic name to Concat nodes:

 concat -> setName(concat->type());

Added a generic name to Slice nodes, while keeping track of the original (Conv) node they are linked to (i.e. node->name):

 slice -> setName(node->name() + '_' + slice->type() + '_' + std::to_string(i));

Minor changes

Added an underscore in the names of Slices' Producers nodes for readability:

auto startsNode = Producer(starts, slice->name() + "_" + sliceInputsNames[1]);

src/recipes/HorizontalTiling.cpp

@@ -62,6 +62,7 @@ std::set<std::shared_ptr<Aidge::Node>> Aidge::getConvHorizontalTiling(const std:
 
 
     auto concat = Concat(nbSlices, axis);
+    concat -> setName(concat->type());
     std::set<std::shared_ptr<Aidge::Node>> tiledOperator{concat};
 
     // check slice sizes
@@ -77,7 +78,7 @@ std::set<std::shared_ptr<Aidge::Node>> Aidge::getConvHorizontalTiling(const std:
     for (std::size_t i = 0; i < node ->nbInputs(); ++i) {
         if (node->inputCategory(i) == InputCategory::Param || node->inputCategory(i) == InputCategory::OptionalParam) {
             clonedInputs[i] = node -> getParent(i) -> cloneSharedOperators();
-            clonedInputs[i] -> setName(node -> getParent(i) -> name() + "_0");
+            clonedInputs[i] -> setName(node -> getParent(i) -> name());
             tiledOperator.insert(clonedInputs[i]);
         }
     }
@@ -93,6 +94,7 @@ std::set<std::shared_ptr<Aidge::Node>> Aidge::getConvHorizontalTiling(const std:
         clonedInputs[2] -> addChild(newNode, 0, 2);
 
         auto slice = Slice();
+        slice -> setName(node->name() + '_' + slice->type() + '_' + std::to_string(i));
         auto backend = outTensor->getImpl()->backend();
 
         // Create Slice's Starts producer node
@@ -105,7 +107,7 @@ std::set<std::shared_ptr<Aidge::Node>> Aidge::getConvHorizontalTiling(const std:
         starts -> setBackend(backend);
         starts -> resize(std::vector<std::size_t>({inputDimsStart.size()}));
         starts -> getImpl() -> copyFromHost(inputDimsStart.data(), inputDimsStart.size());
-        auto startsNode = Producer(starts, slice->name() + sliceInputsNames[1]);
+        auto startsNode = Producer(starts, slice->name() + "_" + sliceInputsNames[1]);
         startsNode -> addChild(slice, 0, 1);
 
         // Create Slice's Ends producer node
@@ -118,7 +120,7 @@ std::set<std::shared_ptr<Aidge::Node>> Aidge::getConvHorizontalTiling(const std:
         ends -> setBackend(backend);
         ends -> resize(std::vector<std::size_t>({inputDimsEnd.size()}));
         ends -> getImpl() -> copyFromHost(inputDimsEnd.data(), inputDimsEnd.size());
-        auto endsNode = Producer(ends, slice->name() + sliceInputsNames[2]);
+        auto endsNode = Producer(ends, slice->name() + "_" + sliceInputsNames[2]);
         endsNode -> addChild(slice, 0, 2);
 
         // Create Slice's Axes producer node
@@ -129,7 +131,7 @@ std::set<std::shared_ptr<Aidge::Node>> Aidge::getConvHorizontalTiling(const std:
         axes -> setBackend(backend);
         axes -> resize(std::vector<std::size_t>({usedDims.size()}));
         axes -> getImpl() -> copyFromHost(usedDims.data(), usedDims.size());
-        auto axesNode = Producer(axes, slice->name() + sliceInputsNames[3]);
+        auto axesNode = Producer(axes, slice->name() + "_" + sliceInputsNames[3]);
         axesNode -> addChild(slice, 0, 3);
 
         // Create Slice's Steps producer node
@@ -139,7 +141,7 @@ std::set<std::shared_ptr<Aidge::Node>> Aidge::getConvHorizontalTiling(const std:
         steps -> setBackend(backend);
         steps -> resize(std::vector<std::size_t>({inputDimsSteps.size()}));
         steps -> getImpl() -> copyFromHost(inputDimsSteps.data(), inputDimsSteps.size());
-        auto stepsNode = Producer(steps, slice->name() + sliceInputsNames[4]);
+        auto stepsNode = Producer(steps, slice->name() + "_" + sliceInputsNames[4]);
         stepsNode -> addChild(slice, 0, 4);
 
         // auto slice = Slice(inputDimsStart, inputDimsEnd, usedDims, inputDimsSteps);