Add support for non-defined inputs and outputs of nodes in show_graphview.py.
Context
The previous code of _create_dict()
function in show_graphview.py
did not take into account the presence of Null
inputs or outputs of a node. The expected behavior is that, when the model is compiled, the forward_dims()
function is able to infer the dimensions of all tensors. However, there may be an issue in the Aidge Graphview when some inputs of the node are implicitely set to zero in ONNX and remain undefined in Aidge (see issue #232 and MR #213).
Modified files
-
aidge/aidge_core/aidge_core/show_graphview.py
, added a check to verify if the node's inputs/outputs are notNull
.
Merge request reports
Activity
assigned to @idealbuq
requested review from @cmoineau
@idealbuq Tell me when this is ready to be reviewed :)
added 1 commit
- 9e7af7a8 - Force path parameter to be a Path object in gview_to_json() function.
added Enhancement ⭐ StatusReview Ready labels
added 20 commits
-
9e7af7a8...c312252d - 19 commits from branch
eclipse/aidge:dev
- 54f7e2ad - Merge remote-tracking branch 'origin/dev' into dev
-
9e7af7a8...c312252d - 19 commits from branch
added 50 commits
-
54f7e2ad...a983179d - 49 commits from branch
eclipse/aidge:dev
- b76020e3 - Merge remote-tracking branch 'origin/dev' into dev
-
54f7e2ad...a983179d - 49 commits from branch
added 8 commits
-
b76020e3...620f9e62 - 7 commits from branch
eclipse/aidge:dev
- 7509361f - Merge remote-tracking branch 'origin/dev' into dev
-
b76020e3...620f9e62 - 7 commits from branch
removed StatusReview Ready label
added 9 commits
-
7509361f...434e21e3 - 8 commits from branch
eclipse/aidge:dev
- 896c9e27 - Merge remote-tracking branch 'origin/dev' into dev
-
7509361f...434e21e3 - 8 commits from branch
enabled an automatic merge when all merge checks for 896c9e27 pass
added 4 commits
-
896c9e27...7643efa9 - 3 commits from branch
eclipse/aidge:dev
- 2706a008 - Merge remote-tracking branch 'origin/dev' into dev
-
896c9e27...7643efa9 - 3 commits from branch
added 14 commits
-
2706a008...25b1ae50 - 13 commits from branch
eclipse/aidge:dev
- 78be44d7 - Merge remote-tracking branch 'origin/dev' into dev
-
2706a008...25b1ae50 - 13 commits from branch
enabled an automatic merge when all merge checks for 78be44d7 pass
mentioned in commit da2cf573