"src/operator/Tanh.cpp" did not exist on "a2aac52e7a678a28e036d8f122d5648ae7d77768"
fix optional inputs in node treated as input for the graph (Fix optional bias in Conv operator)
Context
Conv operators may have optional Bias. In this case, the missing inputs are treated as free available input of the GraphView.
Modified files
- modified: include/aidge/graph/Node.hpp
- modified: src/graph/Node.cpp
Detailed major modifications
- getNbFreeDataInputs : return only the number of available Data and DataOptional (not Params)
- getFirstFreeDataInput : return the first non assignated Data or DataOptional
- AddChild : Instead of getting the first node from the GraphView inputnode, it finds the first input node with data available (which should be unique)
Merge request reports
Activity
Filter activity
added 1 commit
- e998a56f - edit: Node: fix optional inputs in node treated as input graph
added 1 commit
- 4b5384b7 - edit: Node: fix optional inputs in node treated as input graph
added Fix 🔥🔥 label
assigned to @silvanosky
added 44 commits
-
4b5384b7...100e2ef6 - 43 commits from branch
eclipse/aidge:dev
- c55cf4a4 - edit: Node: fix optional inputs in node treated as input graph
-
4b5384b7...100e2ef6 - 43 commits from branch
added StatusReview Ready label
mentioned in merge request !284 (merged)
@olivierbichler Can you review this MR and statuate on wheter or not we accept it?
requested review from @olivierbichler
added 740 commits
-
c55cf4a4...1f6ade51 - 739 commits from branch
eclipse/aidge:dev
- 0970bc45 - edit: Node: fix optional inputs in node treated as input graph
-
c55cf4a4...1f6ade51 - 739 commits from branch
This is an old MR, the same changes have been generalized in !370
Edited by Charles Villard
Please register or sign in to reply