Skip to content

Correct logic for Node's parents/children association with inputs/outputs in aidge_core/show_graphview.py.

Iryna DE ALBUQUERQUE SILVA requested to merge idealbuq/aidge_core:dev into dev

Context

This MR corrects an identified problem within the algorithm allowing to link a Node's parents (or children) nodes to its respective inputs (or outputs) in file aidge_core/show_graphview.py.

In short, only the dimensions of tensors were verified to do the matching, which caused a problem when, for example, multiple Node's inputs (or outputs) had the same dimensions.

Also, it corrects a few errors with the automatic creation of the generated files' paths.

Modified files

  • python_binding/graph/pybind_Node.cpp , added the python binding for the method "get_ordered_children()";
  • aidge_core/show_graphview.py, corrected logic used to link parents/children to inputs/outputs of a Node and management of paths.

Detailed major modifications

Inside the _create_dict method, employ the aidge_core.Node.outputs() method to retrieve the children of the Node's parents and the associated input index connected to each child. Similarly, use aidge_core.Node.inputs() to retrieve the Node's list of children and outputs.

Merge request reports

Loading