Correct logic for Node's parents/children association with inputs/outputs in aidge_core/show_graphview.py.
Context
This MR corrects an identified problem within the algorithm allowing to link a Node's parents (or children) nodes to its respective inputs (or outputs) in file aidge_core/show_graphview.py.
In short, only the dimensions of tensors were verified to do the matching, which caused a problem when, for example, multiple Node's inputs (or outputs) had the same dimensions.
Also, it corrects a few errors with the automatic creation of the generated files' paths.
Modified files
-
python_binding/graph/pybind_Node.cpp
, added the python binding for the method "get_ordered_children()"; -
aidge_core/show_graphview.py
, corrected logic used to link parents/children to inputs/outputs of a Node and management of paths.
Detailed major modifications
Inside the _create_dict
method, employ the aidge_core.Node.outputs()
method to retrieve the children of the Node's parents and the associated input index connected to each child. Similarly, use aidge_core.Node.inputs()
to retrieve the Node's list of children and outputs.
Merge request reports
Activity
added 7 commits
-
781fbe2a...f4437b4d - 2 commits from branch
eclipse/aidge:dev
- 293dda2d - Corrected error in the writing of trainable parameters path in JSON file.
- ff953406 - Improved destination paths management and included support for their automatic creation.
- 42cbe52c - Added pybind for Node's getOrderedChildren function.
- ca95f63c - Corrected logic used to link parents/children to inputs/outputs of a Node.
- 8db95c0e - Removed extra space in start of line.
Toggle commit list-
781fbe2a...f4437b4d - 2 commits from branch
added 9 commits
- a7501d94 - Corrected error in the writing of trainable parameters path in JSON file.
- 7c11f194 - Improved destination paths management and included support for their automatic creation.
- ed7cd886 - Merge remote-tracking branch 'origin/dev' into dev
- 8ea479aa - Added pybind for Node's getOrderedChildren function.
- 03bf0df0 - Merge remote-tracking branch 'origin/dev' into dev
- 7458e9ed - Corrected logic used to link parents/children to inputs/outputs of a Node.
- 781fbe2a - Removed extra space in start of line.
- be5a9fb8 - Merge remote-tracking branch 'origin/dev' into dev
- f5ec7a62 - Merge remote-tracking branch 'fork_idealbuq/dev' into dev
Toggle commit listassigned to @idealbuq
requested review from @cmoineau
enabled an automatic merge when the pipeline for f5ec7a62 succeeds
mentioned in commit bce5965b