Skip to content
Snippets Groups Projects
Commit a90daf94 authored by Octave Perrin's avatar Octave Perrin
Browse files

more

parent 07160e17
No related branches found
No related tags found
No related merge requests found
......@@ -204,9 +204,9 @@ public:
*/
void setOrderedOutputs(const std::vector<std::pair<NodePtr, IOIndex_t>>& outputs);
/** @todo i don't understand the description
* @brief Get a topological node order for an acyclic walk of the graph
* Graph cycles are broken on operator back edges such that resolution on
/**
* @brief Get a topological node order for an acyclic walk of the graph.
* @details Graph cycles are broken on operator back edges such that resolution on
* single level lattice can be done in a single pass as it is
* the case generally for static resolution of Tensor shapes/datatypes.
* When reversed is true, gets a topological order on the reversed graph
......@@ -239,12 +239,12 @@ public:
* @brief List outside data input connections of the GraphView.
* Data inputs exclude inputs expecting parameters (weights or bias).
* The vector size is guaranteed to match the number of outside data inputs of the GraphView. If there is
* no external connection to a given input, a pair of nullptr and gk_IODefaultIndex is returned. @todo check it, for me it seem every unconnected input will add some nullptr to the list
* no external connection to a given input, a pair of nullptr and gk_IODefaultIndex is returned.
* @return std::vector<std::pair<NodePtr, IOIndex_t>>
*/
std::vector<std::pair<NodePtr, IOIndex_t>> dataInputs() const;
/** @todo check it
/**
* @brief List all dataInput connections (within and outside) of the specified GraphView node named "name".
* Data inputs exclude inputs expecting parameters (weights or bias).
* @param name Name of the Node.
......
......@@ -375,7 +375,7 @@ Aidge::IOIndex_t Aidge::GraphView::getNbFreeDataInputs() const {
std::vector<std::pair<std::shared_ptr<Aidge::Node>, Aidge::IOIndex_t>>
Aidge::GraphView::dataInputs() const {
std::vector<std::pair<std::shared_ptr<Node>, IOIndex_t>> res;
std::vector<std::pair<std::shared_ptr<Node>, IOIndex_t>> res; //todo three letters or less variable names should be illegal
for (const std::shared_ptr<Node>& inputNode : inputNodes()) {
const std::vector<std::pair<std::shared_ptr<Node>, IOIndex_t>> inputNodeinputs =
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment